Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: advanced-security/ghas-reviewer-app
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.6.0
Choose a base ref
...
head repository: advanced-security/ghas-reviewer-app
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 4 commits
  • 3 files changed
  • 2 contributors

Commits on Dec 17, 2024

  1. docs: Update README.md

    @GeekMasher
    GeekMasher authored Dec 17, 2024
    Configuration menu
    Copy the full SHA
    8877538 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2024

  1. Fix severity check logic and make it configurable 

    Fixes #89

Update the Reviewer app to make severity list configurable and handle security severity level.

* Add `--ghas-severities` argument to `ghasreview/setup.py` to allow configuration through environment variables or arguments.
* Modify `ghasreview/app.py` to check both `alert.severity` and `alert.payload.rule.security_severity_level` against the configurable severity list.
* Add logic to handle the case where no severity values are provided, reopening all findings.
* Log the configured severities and the results of severity checks.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/advanced-security/ghas-reviewer-app/issues/89?shareId=XXXX-XXXX-XXXX-XXXX).
    @GeekMasher
    GeekMasher committed Dec 18, 2024
    Configuration menu
    Copy the full SHA
    53a56fa View commit details
    Browse the repository at this point in the history

  2. Add documentation on how to set the GHAS severity flag 

    * Add a new section for GHAS Severities in the README.md
* Provide an example of setting the `GITHUB_GHAS_SEVERITIES` environment variable
    @GeekMasher
    GeekMasher committed Dec 18, 2024
    Configuration menu
    Copy the full SHA
    e65181f View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2024

  1. Merge pull request #90 from advanced-security/GeekMasher/fix-severity… 

    …-check

Fix severity check logic and make it configurable
    @theztefan
    theztefan authored Dec 19, 2024
    Configuration menu
    Copy the full SHA
    2d5f25e View commit details
    Browse the repository at this point in the history
Loading