Skip to content

Commit 0f554bd

Browse files
committed
UI5: Address join order issues with inSameWebApp
Applying inSameWebApp too early in the pipeline was causing a cross-product on all data flow nodes in a WebApp. It's typically better to apply the other conditions (e.g. name matching), then filter on the same web-app as a final step.
1 parent 0b7b119 commit 0f554bd

File tree

1 file changed

+2
-0
lines changed
  • javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5

1 file changed

+2
-0
lines changed

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ class WebAppManifest extends File {
7878
WebApp getWebapp() { result = webapp }
7979
}
8080

81+
bindingset[f1, f2]
82+
pragma[inline_late]
8183
predicate inSameWebApp(File f1, File f2) {
8284
exists(WebApp webApp | webApp.getAResource() = f1 and webApp.getAResource() = f2)
8385
}

0 commit comments

Comments
 (0)