Skip to content

Conversation

@adrienpessu
Copy link
Collaborator

This pull request to src/main/kotlin/com/github/adrienpessu/sarifviewer/toolWindow/SarifViewerWindowFactory.kt includes changes to improve the handling of Leaf objects and error notifications for file not found. The most important changes include adding a currentLeaf variable to store the current Leaf object, changing the usage of Leaf to currentLeaf, and adding error handling when the file is not found.

Here are the most important changes:

@github-actions
Copy link

github-actions bot commented Apr 10, 2024

Qodana Community for JVM

17 new problems were found

Inspection name Severity Problems
Incorrect string capitalization 🔶 Warning 3
Redundant SAM constructor 🔶 Warning 2
Local 'var' is never modified and can be declared as 'val' 🔶 Warning 1
Unused symbol 🔶 Warning 1
Property naming convention ◽️ Notice 6
Unnecessary parentheses in function call with lambda ◽️ Notice 2
Object literal can be converted to lambda ◽️ Notice 1
Accessor call that can be replaced with property access syntax ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.2
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@adrienpessu adrienpessu merged commit 827eb24 into main Apr 10, 2024
@adrienpessu adrienpessu deleted the fix/path_resolution branch April 10, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants