Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to update #3

Open
pkzOR opened this issue Aug 16, 2023 · 0 comments
Open

Request to update #3

pkzOR opened this issue Aug 16, 2023 · 0 comments

Comments

@pkzOR
Copy link

pkzOR commented Aug 16, 2023

I'm trying to use your OAuth plugin in a CapacitorJS generated version of an Electron app.

I've added "@advanced-rest-client/electron-oauth2": "^5.1.1", to the electron/package.json.
but that generates a npm error:
Could not resolve dependency:
npm ERR! peer electron@"^13.1.1" from @advanced-rest-client/electron-oauth2@5.1.1

We are using Electron 19.0.0. This seems like an npm error, so I run npm install --force to get the app to build.

When I run the app I get:

SyntaxError: The requested module 'file:///xxxx/electron/electron' does not provide an export named 'BrowserWindow'
at Object. (xxxx\electron\node_modules@advanced-rest-client\electron-oauth2\lib\Oauth2Identity.js:1)
at Generator.next ()
at Object. (xxxx\electron\node_modules@advanced-rest-client\electron-oauth2\main.js:1)
at Generator.next ()
at Object. (xxxx\electron\node_modules@advanced-rest-client\electron-oauth2\index.js:2:18)
at Object. (xxxx\electron\node_modules@advanced-rest-client\electron-oauth2\index.js:4:3)
at Module._compile (node:internal/modules/cjs/loader:1118:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1173:10)

I am wondering if you could update your package (5.1.2) to use a newer version of electron to avoid --force and any other changes that may fix the runtime error.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant