Skip to content

[W-12465439] Missing boundary for multipart content type #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

carowright
Copy link
Contributor

Bug

Missing boundary for multipart content type

Fix

According to form data documentation: do not explicitly set the Content-Type header on the request. Doing so will prevent the browser from being able to set the Content-Type header with the boundary expression it will use to delimit form fields in the request body.
When payload is FormData and multipart content-type, then that header will be removed so it can be calculated with its boundary.

@carowright carowright requested a review from alexpmule January 31, 2023 19:04
Copy link
Contributor

@alexpmule alexpmule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carowright carowright merged commit 91f9439 into main Feb 1, 2023
@carowright carowright deleted the fix/W-12465439/missing-boundary branch February 1, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants