New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URI::encode throws warning: URI.escape is obsolete #42

Open

adrianshort opened this issue Jun 29, 2021 · 0 comments

Assignees

Labels

bug northgate scraper

Owner

adrianshort commented Jun 29, 2021 •

edited

Loading

Currently from these lines in northgate.rb:

results_url = URI::encode(base_url + response2.headers['Location'].gsub!('PS=10', 'PS=99999'))

app.info_url = URI::encode(generic_url + cells[0].at('a')[:href].strip)

We need to improve the URL escaping by understanding what's precisely required here and doing it properly.

This post gives some guidance:

https://docs.knapsackpro.com/2020/uri-escape-is-obsolete-percent-encoding-your-query-string

adrianshort added bug northgate scraper labels

adrianshort self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment