Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case_officer_code modifies Authority url param #41

Open
adrianshort opened this issue Jun 28, 2021 · 0 comments
Open

case_officer_code modifies Authority url param #41

adrianshort opened this issue Jun 28, 2021 · 0 comments
Assignees
Labels
bug Something isn't working northgate scraper

Comments

@adrianshort
Copy link
Owner

adrianshort commented Jun 28, 2021

How to reproduce:

auth = UKPlanningScraper::Authority.named("X") # Northgate authorities only
apps1 = auth.case_officer_code("123").decided_days(7).scrape
apps2 = auth.decided_days(7).scrape

This fails because the url param of Authority has been modified so the apps2 call to scrape fails because it's trying to scrape from the case officer page rather than the general search page.

The url param needs to stay constant throughout the lifetime of the object so scrape will always be requesting the right URL.

@adrianshort adrianshort added bug Something isn't working northgate scraper labels Jun 28, 2021
@adrianshort adrianshort self-assigned this Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working northgate scraper
Projects
None yet
Development

No branches or pull requests

1 participant