Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Client authenticationFlowBindingOverrides an empty list is compared to null which leads to unnecessary client updates #883

Open
srose opened this issue Jun 12, 2023 · 0 comments
Labels

Comments

@srose
Copy link
Contributor

srose commented Jun 12, 2023

Current Behavior

When checking authenticationFlowBindingOverrides of a client the client from file has set null and the corresponding client retrieved via API has set an empty list. This leads to an unnecessary CLIENT UPDATE event.

Expected Behavior

Compare null and empty list of authenticationFlowBindingOverrides in a consistent way.

Steps To Reproduce

1. Definition of a client in yaml/json
2. Run Import
3. Change the file, but not the client definition to make the import logic start again
4. Run Import
5. See UPDATE CLIENT Event for the client not changed.

Environment

  • Keycloak Version: 21.1.1
  • keycloak-config-cli Version: 5.6.1
  • Java Version: 17

Anything else?

Comments/thoughts welcome...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Dev
Development

No branches or pull requests

1 participant