-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial VDR generation pipeline #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Scanteianu !
Perhaps remove the cached .json files from the data folder so they do not get checked in with the rest of these changes, if they are just a side-effect of a local run. Can also add a .gitignore file so that when someone is working on PRs for this repository and running tests locally, they do not accidentally include working / cached files in their pull requests.
Thanks @smlambert , should i keep the downloads of the website? (the htmls)? In an ideal world i'd put all this stuff in some kind of database, but i'm not sure we need that much complexity yet. The goal is to avoid putting load on nist/ojvg every time we run the tool |
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Scanteianu !!
Will merge this, then create several issues for next steps (setting up regular run, potentially integrating into overall release pipeline, etc).
Migration from Scanteianu/openjdk-cve-parser#2, which in turn is a fork of https://github.com/Scanteianu/openjdk-cve-parser.
Stuff in the data directory can be ignored, it's essentially a cache (except for vdr.json, which is the final output)