Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial VDR generation pipeline #1

Merged
merged 10 commits into from
Mar 20, 2024

Conversation

Scanteianu
Copy link
Contributor

Migration from Scanteianu/openjdk-cve-parser#2, which in turn is a fork of https://github.com/Scanteianu/openjdk-cve-parser.

Stuff in the data directory can be ignored, it's essentially a cache (except for vdr.json, which is the final output)

Copy link

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Scanteianu !

Perhaps remove the cached .json files from the data folder so they do not get checked in with the rest of these changes, if they are just a side-effect of a local run. Can also add a .gitignore file so that when someone is working on PRs for this repository and running tests locally, they do not accidentally include working / cached files in their pull requests.

@Scanteianu
Copy link
Contributor Author

Thanks @Scanteianu !

Perhaps remove the cached .json files from the data folder so they do not get checked in with the rest of these changes, if they are just a side-effect of a local run. Can also add a .gitignore file so that when someone is working on PRs for this repository and running tests locally, they do not accidentally include working / cached files in their pull requests.

Thanks @smlambert , should i keep the downloads of the website? (the htmls)? In an ideal world i'd put all this stuff in some kind of database, but i'm not sure we need that much complexity yet. The goal is to avoid putting load on nist/ojvg every time we run the tool

@Scanteianu Scanteianu requested a review from smlambert March 18, 2024 14:24
Scanteianu and others added 4 commits March 20, 2024 08:21
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
@Scanteianu Scanteianu requested a review from karianna March 20, 2024 08:32
Copy link

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Scanteianu !!

Will merge this, then create several issues for next steps (setting up regular run, potentially integrating into overall release pipeline, etc).

@smlambert smlambert merged commit c6366d0 into adoptium:main Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants