Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src.zip is non-determinstic if content file attributes differ between builds #3153

Open
andrew-m-leonard opened this issue Nov 9, 2022 · 2 comments
Open

src.zip is non-determinstic if content file attributes differ between builds #3153

andrew-m-leonard opened this issue Nov 9, 2022 · 2 comments
Labels
macos Issues that affect or relate to the MAC OS reproducible-build

Comments

@andrew-m-leonard
Copy link
Contributor

If two builds on different machines have different group file attributes, then the compressed src.zip will contain differing file permissions and thus be non-reproducible.
@github-actions github-actions bot added the macos Issues that affect or relate to the MAC OS label Nov 9, 2022
@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Nov 9, 2022 •
edited
Loading

Upstream Zip creation specifically preserves the file permissions, ref: https://bugs.openjdk.org/browse/JDK-8277069

Building with a user that has the same "User|Group|All" permission levels maybe necessary on the two builds to successfully compare.
Or for the "comparison" inflate the src.zip, like we do for the "modules" image.

@zdtsw
Copy link
Contributor

zdtsw commented Nov 16, 2022 •
edited
Loading

Ref: Capture all findings for reproducible builds #3074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
macos Issues that affect or relate to the MAC OS reproducible-build
Projects
Adoptium Backlog
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zdtsw @andrew-m-leonard