Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/jrt-fs.jar MANIFEST is non-determinstic if built with different BootJDK #3151

Open
andrew-m-leonard opened this issue Nov 9, 2022 · 5 comments

Comments

@andrew-m-leonard
Copy link
Contributor

andrew-m-leonard commented Nov 9, 2022

jrt-fs.jar is built by the BootJDK, which has a consequence that the MANIFEST gets tagged with Created-By: (), where jdk-version and vendor are from the bootJDK.
eg.

Manifest-Version: 1.0
Specification-Title: Java Platform API Specification
Specification-Version: 20
Specification-Vendor: Oracle Corporation
Implementation-Title: Java Runtime Environment
Implementation-Version: 20
Implementation-Vendor: Eclipse Adoptium
Created-By: 19.0.1 (Eclipse Adoptium)
Manifest-Version: 1.0
Specification-Title: Java Platform API Specification
Specification-Version: 20
Specification-Vendor: Oracle Corporation
Implementation-Title: Java Runtime Environment
Implementation-Version: 20
Implementation-Vendor: Eclipse Adoptium
Created-By: 19-beta (Eclipse Adoptium)
@zdtsw
Copy link
Contributor

zdtsw commented Nov 15, 2022

is this Jrtfs.jar for certain OS? I could not find it from a x64 linux tarball

@andrew-m-leonard andrew-m-leonard changed the title Jrtfs.jar MANIFEST is non-determinstic if built with different BootJDK lib/jrt-fs.jar MANIFEST is non-determinstic if built with different BootJDK Nov 15, 2022
@andrew-m-leonard
Copy link
Contributor Author

Sorry my shorthand, it's: lib/jrt-fs.jar

@zdtsw
Copy link
Contributor

zdtsw commented Nov 15, 2022

Now i found it in linux, mac and windows.
should it be added into exclude list with classes_nocoops.jsa for now ?

probably this wont need to be exclude in comparision job, because all our agents are supposed to have the same bootjdk.

but maybe we need to add this bootjdk version into sbom? currently it is only the boot_jdk_dir point to the path on build agent, but not detail minor/patch version number

@andrew-m-leonard
Copy link
Contributor Author

@zdtsw not an exclude, we can build with same bootjdk version.
And yes +1 to updating SBOM bootjdk details please..

@zdtsw
Copy link
Contributor

zdtsw commented Nov 16, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants