Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build in gcc 9 #2250

Open
joeyleeeeeee97 opened this issue Nov 23, 2020 · 8 comments
Open

Support build in gcc 9 #2250

joeyleeeeeee97 opened this issue Nov 23, 2020 · 8 comments
Labels
code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts docker Issues related to our docker files and docker scripts enhancement Issues that enhance the code or documentation of the repo in any way infra Issues that related to infrastructure problems or enhancements

Comments

@joeyleeeeeee97
Copy link
Contributor

Some features or performance optimizations in JVM may need a higher version of GCC.

Maybe we could add gcc9 build config in a separate docker image.

@M-Davies
Copy link
Contributor

Related #451.

We don't have gcc 9 installed on the machines so this is likely an openjdk-infrastructure first and then openjdk-build issue to get it configured. @karianna Can you move this over to inf?

@aahlenst aahlenst transferred this issue from adoptium/temurin-build Nov 23, 2020
@sxa
Copy link
Member

sxa commented Nov 23, 2020

@M-Davies I wold suggest that unless there's a decision on this (which would require openjdk-build adjustments) this is the correct home for it, with a separate issue if we choose to install it)

@joeyleeeeeee97 We build most of them on gcc 7.5 now. Is there a specific thing that you are aware of which is advantageous when build with gcc 9 - I presume there's something you're aware of since you haven't picked gcc 10 :-)

@aahlenst aahlenst transferred this issue from adoptium/infrastructure Nov 23, 2020
@aahlenst
Copy link
Contributor

I can do issue transfers the whole day 😂

@M-Davies M-Davies added code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts enhancement Issues that enhance the code or documentation of the repo in any way infra Issues that related to infrastructure problems or enhancements labels Nov 23, 2020
@joeyleeeeeee97
Copy link
Contributor Author

@M-Davies I wold suggest that unless there's a decision on this (which would require openjdk-build adjustments) this is the correct home for it, with a separate issue if we choose to install it)

@joeyleeeeeee97 We build most of them on gcc 7.5 now. Is there a specific thing that you are aware of which is advantageous when build with gcc 9 - I presume there's something you're aware of since you haven't picked gcc 10 :-)

Yes. We find higher version of gcc brings significant benefits on some microbenchmarks. The reason we chose gcc9 is mostly that gcc 10 haven't be widely used in Alibaba. :)

@sxa
Copy link
Member

sxa commented Nov 24, 2020

Yes. We find higher version of gcc brings significant benefits on some microbenchmarks. The reason we chose gcc9 is mostly that gcc 10 haven't be widely used in Alibaba. :)

Thanks for the info. In that case I think we should certainly look at setting up Linux/x64 with gcc-9 for the Dragonwell builds only initially :-)

@sxa
Copy link
Member

sxa commented Nov 24, 2020

@joeyleeeeeee97 Are the microbenchmarks that show up the improvements available in the open?

@joeyleeeeeee97
Copy link
Contributor Author

@joeyleeeeeee97 Are the microbenchmarks that show up the improvements available in the open?

Spec tests(specjbb2015) performance is better, for a specific number and cases we could do this once we got a gcc9 dragonwell to compare with its gcc7 version. :)

@sxa
Copy link
Member

sxa commented Jan 7, 2022

FYI We are in the process of installing GCC10.3 for JDK17u onto the build systems, so if we choose to use that version instead of GCC9 we can switch up (and stop installing 9)

@github-actions github-actions bot added the docker Issues related to our docker files and docker scripts label Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts docker Issues related to our docker files and docker scripts enhancement Issues that enhance the code or documentation of the repo in any way infra Issues that related to infrastructure problems or enhancements
Projects
Status: Todo
Development

No branches or pull requests

4 participants