Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK8/HotSpot/arm32 builds don't have AdoptOpenJDK in java -version #2229

Closed
sxa opened this issue Nov 13, 2020 · 3 comments
Closed

JDK8/HotSpot/arm32 builds don't have AdoptOpenJDK in java -version #2229

sxa opened this issue Nov 13, 2020 · 3 comments
Assignees
Labels
arm Issues that affect or relate to the ARM OS bug Issues that are problems in the code as reported by the community
Milestone

Comments

@sxa
Copy link
Member

sxa commented Nov 13, 2020

What are you trying to do?

Run java -version on the JDK8/HotSpot builds on arm 320bit

Expected behaviour:

To see AdoptOpenJDK in the output as per other platforms e.g. here is Linux/s390x's equivalent output:

openjdk version "1.8.0_275"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_275-b01)
OpenJDK 64-Bit Zero VM (AdoptOpenJDK)(build 25.275-b01, interpreted mode)

Observed behaviour:

No AdoptOpenJDK string:

openjdk version "1.8.0_275"
OpenJDK Runtime Environment (build 1.8.0_275-b01)
OpenJDK Client VM (build 25.275-b01, mixed mode)

Any other comments:

@sxa sxa added the bug Issues that are problems in the code as reported by the community label Nov 13, 2020
@sxa sxa added this to the November 2020 milestone Nov 13, 2020
@M-Davies M-Davies added the arm Issues that affect or relate to the ARM OS label Nov 14, 2020
@adamfarley adamfarley self-assigned this Nov 26, 2020
@adamfarley
Copy link
Contributor

Taking a look.

@adamfarley
Copy link
Contributor

adamfarley commented Nov 26, 2020

Ok, the vendor is being correctly passed in via "--with-vendor-name" in the configure step, so I'm currently googling and poking through jdk8 code to try and figure out why it doesn't end up in the -version output like it does in jdk8 zLinux and jdk11 arm.

Edit: The "dev" and "master" branches of the arm-specific jdk8u source lack the code required to add the vendor name in this fashion. The multiplatform jdk8u code has this addition in the "dev" branch, but not the "master" branch, so I assume that the arm code base (both dev and master) is based off of the multiplatform's "master" code base, and that the change simply hasn't been ported yet.

Going on a commit hunt now.

@adamfarley
Copy link
Contributor

All fixed as per this PR.

AdoptOpenJDK/openjdk-aarch32-jdk8u#1

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues that affect or relate to the ARM OS bug Issues that are problems in the code as reported by the community
Projects
None yet
Development

No branches or pull requests

4 participants