Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command "run tests" has poor usability #2055

Closed
aahlenst opened this issue Sep 7, 2020 · 3 comments
Closed

Command "run tests" has poor usability #2055

aahlenst opened this issue Sep 7, 2020 · 3 comments
Assignees
Labels
enhancement Issues that enhance the code or documentation of the repo in any way jenkins Issues that enhance or fix our jenkins server

Comments

@aahlenst
Copy link
Contributor

aahlenst commented Sep 7, 2020

If someone types "run test", PR comments should be added that provide diagnostics.

  • If the person is not whitelisted to do "run tests", the user should be informed that they aren't allowed to run the command and be instructed how to fix this.
  • If the request was queued, a link to the build should be provided.
  • If the build was finished, a summary of the results should be provided.
@aahlenst aahlenst added enhancement Issues that enhance the code or documentation of the repo in any way jenkins Issues that enhance or fix our jenkins server labels Sep 7, 2020
@aahlenst
Copy link
Contributor Author

aahlenst commented Sep 7, 2020

Related: #2053

@M-Davies
Copy link
Contributor

M-Davies commented Sep 8, 2020

If the person is not whitelisted to do "run tests", the user should be informed that they aren't allowed to run the command and be instructed how to fix this.

Unfortunately, this currently isn't possible with the plugin that we're using. It looks like there's a pull request in to attempt to make this change in the plugin's repo but even then I'm not confident much will happen seeing as it's 3 years old jenkinsci/ghprb-plugin#495. We could try and do some hacky stuff with the bot but I don't currently have access to the code to run that (@johnoliver do you have any idea how @adoptopenjdk-github-bot works?)

If the request was queued, a link to the build should be provided.

The plugin provides support for that by default. By setting the Commit Status Build Triggered and Commit Status Build Started configure settings in the pr-tester, we can customise the status that is displayed on Github. See below image for when a job is in the queue:
Screenshot 2020-09-08 at 11 06 13
and this image for when the job is out of the queue and currently running (this may be defunct if I can get the PR tester running concurrently but it'll do for now)
Screenshot 2020-09-08 at 12 13 11

If the build was finished, a summary of the results should be provided.

Again, the plugin can help us here. By setting the Build Result Message configure setting in the tester, we can get the adopt bot to comment when the build succeeds, fails or errors
Screenshot 2020-09-08 at 12 15 01

I'll add documentation summarising all of this as part of #2056

@M-Davies
Copy link
Contributor

M-Davies commented Sep 8, 2020

This has been applied to the pipeline tester but not the groovy compiler as that takes about 30 seconds to run at max and I don't have the perms to modify it anyway

@M-Davies M-Davies closed this as completed Sep 8, 2020
@karianna karianna added this to the September 2020 milestone Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that enhance the code or documentation of the repo in any way jenkins Issues that enhance or fix our jenkins server
Projects
None yet
Development

No branches or pull requests

3 participants