Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert new directory naming for jdk 8 releases #1032

Closed
karianna opened this issue Apr 12, 2019 · 2 comments
Closed

Revert new directory naming for jdk 8 releases #1032

karianna opened this issue Apr 12, 2019 · 2 comments
Assignees
Labels
bug Issues that are problems in the code as reported by the community
Milestone

Comments

@karianna
Copy link
Contributor

karianna commented Apr 12, 2019

Initial report:

I have been building the openjdk8-openj9 milestone 1 builds for the upcoming quarterly release.  Most of the jobs ran OK - the builds are at https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/tag/jdk8u212-b01_openj9-0.14.0-m1.  I have a question about the top level directory in the download archives.  For the Jan update the top level directory was jdk8u202-b08.  For this release it is jdk-8.0.212 (the latest tag level in the open9-openjdk-jdk8 extensions repository is jdk8u212-b01).   For the jdk11 Jan update it was jdk-11.0.2+9.  What determines what this directory will be called?  Was the change for jdk8 intentional - or does it imply something was incorrect in the build parameters I used?  If it is intentional, shouldn't the name also include the build level - e.g. jdk-8.0.212-b01?  In order for openjdk-hotspot and openjdk-openj9 to coexist perhaps the openj9 level should be appended to the directory name - e.g. jdk-8.0.212_openj9-0.14.0?

Discussed on a build team call - we will revert to the jdk-8.0.212-b01 style naming for now and resolve fully in #1016 going forward

@karianna
Copy link
Contributor Author

We will unify this later in #1016

@karianna karianna added this to the April 2019 milestone Apr 12, 2019
@karianna karianna added the bug Issues that are problems in the code as reported by the community label Apr 12, 2019
@karianna
Copy link
Contributor Author

See #1034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that are problems in the code as reported by the community
Projects
None yet
Development

No branches or pull requests

2 participants