Generated MSIs lack end-user license agreement

[jmjaffe37]

Not sure if this was a desired change, but we recently noticed that the generated MSIs (windows installers) will no-longer show the End-User License Agreement page (see example below of what the page looks like). I looked for a while, but I could not find the code change that lead to this

[gdams]

@jmjaffe37 I noticed this when testing, it looks like we need to add this back as part of the flow.

[jmjaffe37]

Looks like this was implemented as a feature request in #162 (since agreeing to the GPL2 license is optional for software users)

[karianna]

I guess we need to provide an override capability.

[jmjaffe37]

I guess we need to provide an override capability.

The override capability was already implemented by @douph1. It depends on the JVM:

• For Openj9, the license-OpenJ9.en-us.rtf license is shown
• For hotspot, the license-GPLv2+CE.en-us.rtf is used (and skipped since it is optional)
• Otherwise it says that there is no license defined for other custom JVMs

[jmjaffe37]

I should be able to add in the capability for the user specify that they want to show the optional GPL license. Would that be preferable?

[karianna]

I think we need to alter it so it's not vm based but "vm and vendor" based. I know that other non Adoptium vendors also have EULA's (on a hotspot base).

[jmjaffe37]

I think we need to alter it so it's not vm based but "vm and vendor" based. I know that other non Adoptium vendors also have EULA's (on a hotspot base).

Ok, that can be arranged

[jmjaffe37]

I think we need to alter it so it's not vm based but "vm and vendor" based. I know that other non Adoptium vendors also have EULA's (on a hotspot base).

Feature added in #851. Also added sample code and an explanation of how to implement custom end-user license behavior in the readme

[jmjaffe37]

The vendor_based license logic has been removed (as was decided recently), but the README now has documentation on license behavior. If similar logic is desired in the future, it will be quick and easy to implement

[karianna]

Thank you!