Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate, retrospect on and update the PR tester #1049

Open
sxa opened this issue Jun 20, 2024 · 0 comments
Open

Evaluate, retrospect on and update the PR tester #1049

sxa opened this issue Jun 20, 2024 · 0 comments
Labels
arm enhancement generation Issues that provide enhancements or fixes to the job generators testing

Comments

@sxa
Copy link
Member

sxa commented Jun 20, 2024

The PR tester job (docs are here) is somewhat neglected and hasn't had some updates for a while so now feels like a good time to look at a bit of a retrospective/overhaul. As a discussion starter some specific issues I note are:

  • It includes JDK20 which is out of support
  • It does not include the head stream (and possibly one release from a branch in the jdk repository to trap issues with the new branching process upstream)
  • It should possible include JDK8/arm32 which is "unusual" in coming from a separate codebase.
  • Maybe include AIX as well for some versions?
  • Could we encourage its use for testing things in temurin-build too, particularly if it is modified to include some of the additional platforms not covered by the existing github actions checks?
  • It is generating unnecessary warnings in the jenkins logs. I believe the jobs should be generated automatically at the start of each run so that theoretically shouldn't be a problem.

We should use this as an opportunity to see if there are specific scenarios/platforms that it would be useful to include in the PR tester to find any problems that we see, so perhaps a brainstorming session is in order. Perhaps JDK8 should include arm32 and Solaris, and potentially other versions can include AIX as additional checks.

@github-actions github-actions bot added arm generation Issues that provide enhancements or fixes to the job generators testing labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm enhancement generation Issues that provide enhancements or fixes to the job generators testing
Projects
Status: Todo
Development

No branches or pull requests

1 participant