Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the grinder doing more work than required? #3986

Open
pshipton opened this issue Sep 22, 2022 · 2 comments
Open

Is the grinder doing more work than required? #3986

pshipton opened this issue Sep 22, 2022 · 2 comments

Comments

@pshipton
Copy link
Contributor

Describe the bug
I started a grinder using "NodesByIterations" on 5 machines. The parent job loads all the repos and downloads the JVM, only to create 5 child jobs that actually runs the testing. It seems loading the repos and downloading the JVM in the parent job is a waste of time.
https://openj9-jenkins.osuosl.org/job/Grinder/1292/console

To Reproduce
Steps to reproduce the behavior (or Grinder rerun link):

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@llxia
Copy link
Contributor

llxia commented Sep 22, 2022

I agree. We only need to download JVM to run TKG when PARALLEL=Dynamic. In other parallel cases (i.e., NodesByIterations, Subdir), we do not need to download JVM and clone test repos.

@llxia
Copy link
Contributor

llxia commented Nov 2, 2022

As @AdamBrousseau pointed out, there is another corner case where PARALLEL=Dynamic and NUM_MACHINES > 1, but the available machine is only 1. In this case, we should run it serially (not launching the child job).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants