Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing JTReg: java/io/CharArrayReader/OverflowInRead.java #1500

Closed
M-Davies opened this issue Dec 10, 2019 · 9 comments
Closed

Failing JTReg: java/io/CharArrayReader/OverflowInRead.java #1500

M-Davies opened this issue Dec 10, 2019 · 9 comments
Assignees
Labels
Milestone

Comments

@M-Davies
Copy link
Contributor

M-Davies commented Dec 10, 2019

https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/d24795242d614819423ba3b48f91e61c7f675a6c/test/jdk/java/io/CharArrayReader/OverflowInRead.java#L1 fails intermittently for JDK11/13 on all platforms

  • Category: openjdk
  • Testname: java/io/CharArrayReader/OverflowInRead.java
  • Jenkins can't seem to find the test but it can find the file OverflowInRead.java, producing a Test results: no tests selected result (perhaps due to the absence of a @Test flag in the main method?).
  • Ran locally, the test passes without issue on mac, windows and linux for JDK11 & 13 when using the "quick and dirty" method of running tests (e.g. `./java -jar jtreg.jar OverflowInRead.java) but also when running the test as per https://github.com/eclipse/openj9/wiki/Reproducing-Test-Failures-Locally. JDK versions are the same (on jenkins and local)
  • Yet this test is excluded anyway (probably due to the previously mentioned Jenkins result)
    Is this the appropriate place to raise this problem?
@smlambert
Copy link
Contributor

smlambert commented Dec 12, 2019

Investigate the annotations at the top of the test, do we have the proper settings in our playlists?

example, this test has a @requires tag, we may need to restrict this test to machines with certain capabilities or set some JVM options for the run
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/d24795242d614819423ba3b48f91e61c7f675a6c/test/jdk/java/io/CharArrayReader/OverflowInRead.java#L27

@sophia-guo
Copy link
Contributor

Good catch, I just googled
@requires
Express a dependence on characteristics of the system being tested, which is supported by jtreg framework. Should not need any manual setting.

To confirm I just run a grinder on linux with jdk_custom=test/jdk/java/io/CharArrayReader/OverflowInRead.java

https://ci.adoptopenjdk.net/view/work%20in%20progress/job/Grinder_Sandbox/982/console

03:27:49  Test results: no tests selected

Tried also with 'openjdk_sparcv9_solaris' as it is sun.arch unfortunately the machine has not setup correctly.
https://ci.adoptopenjdk.net/view/work%20in%20progress/job/Grinder_Sandbox/984/

To double check could also search another test with @requires tag asking other platforms.

@M-Davies
Copy link
Contributor Author

That'll teach me to double check the details at the top of the test instead of diving straight into the code! Thank you both :). Seeing as we don't have any working solaris machines at hyc either, I'll try and test this locally on a solaris VM

@M-Davies M-Davies changed the title Route Failing JTReg to correct repo Failing JTReg: java/io/CharArrayReader/OverflowInRead.java Dec 13, 2019
@M-Davies
Copy link
Contributor Author

Currently waiting for my solaris SPARC approval to go through so until then, there's not much else I can do for this. I'll comment again if I get approved
https://www.oracle.com/solaris/solaris11/downloads/solaris11-vm-templates-downloads.html

@karianna karianna added the bug label Jan 8, 2020
@karianna karianna added this to the January 2020 milestone Jan 8, 2020
@M-Davies
Copy link
Contributor Author

M-Davies commented Jan 8, 2020

A month down the line without approval. I'll send another request.

@M-Davies
Copy link
Contributor Author

M-Davies commented Jan 8, 2020

@smlambert Does adopt distribute solaris-hotspot-jdk11 from the website? I can see a solaris jdk8 but no jdk11

@smlambert
Copy link
Contributor

No, we currently do not have a jdk11 solaris build, see adoptium/temurin-build#1279

@M-Davies
Copy link
Contributor Author

M-Davies commented Jan 8, 2020

Are there any other builds at adopt that are sun.arch? If not, without the architecture to run the test on at the moment, this issue can be closed for now and picked up when jdk11 is supported on solaris

@karianna karianna modified the milestones: January 2020, February 2020 Feb 3, 2020
@smlambert
Copy link
Contributor

agree, closing this issue now (since no jdk11 on solaris) or hardware setup for testing jdk8 build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants