Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-ms DLLs should not be redistributed #564

Closed
khourig opened this issue Aug 16, 2022 · 16 comments
Closed

api-ms DLLs should not be redistributed #564

khourig opened this issue Aug 16, 2022 · 16 comments
Labels
bug Something isn't working stale windows

Comments

@khourig
Copy link

khourig commented Aug 16, 2022

Please provide a brief summary of the bug

The api-ms DLLs are to be distributed by Microsoft only and are installed by Windows Update.

The permitted distributable DLLs are listed here https://docs.microsoft.com/en-us/visualstudio/releases/2022/redistribution

Please provide steps to reproduce where possible

No response

Expected Results

No api-ms DLLs installed.

Actual Results

Some api-ms DLLs installed.

What Java Version are you using?

JDK11.0.14.1

What is your operating system and platform?

No response

How did you install Java?

No response

Did it work before?

No response

Did you test with other Java versions?

No response

Relevant log output

No response

@khourig khourig added the bug Something isn't working label Aug 16, 2022
@gdams
Copy link
Member

gdams commented Aug 22, 2022

@khourig can you specify where these api-ms DLLs are located? I'll follow up once I've got confirmation

@khourig
Copy link
Author

khourig commented Aug 22, 2022

For instance: jdk11.0.14.1\bin\api-ms-win-core-console-l1-1-0.dll

@github-actions
Copy link

We are marking this issue as stale because it has not been updated for a while. This is just a way to keep the support issues queue manageable.
It will be closed soon unless the stale label is removed by a committer, or a new comment is made.

@github-actions github-actions bot added the stale label Nov 21, 2022
@karianna karianna removed the stale label Nov 22, 2022
@karianna
Copy link
Contributor

This still needs investigating

@github-actions
Copy link

We are marking this issue as stale because it has not been updated for a while. This is just a way to keep the support issues queue manageable.
It will be closed soon unless the stale label is removed by a committer, or a new comment is made.

@github-actions github-actions bot added the stale label Feb 21, 2023
@karianna karianna added windows and removed stale labels Feb 21, 2023
@khourig
Copy link
Author

khourig commented Apr 24, 2023

Is there a time table for this to be addressed?

@karianna
Copy link
Contributor

@khourig It's not on our priority list presently, so will require a volunteer to pick it up

@github-actions
Copy link

We are marking this issue as stale because it has not been updated for a while. This is just a way to keep the support issues queue manageable.
It will be closed soon unless the stale label is removed by a committer, or a new comment is made.

@github-actions github-actions bot added the stale label Jul 25, 2023
@karianna
Copy link
Contributor

@gdams I'm not sure I'm understanding this use case, is this expected behaviour for all OpenJDK distros?

@karianna karianna removed the stale label Jul 26, 2023
@github-actions
Copy link

We are marking this issue as stale because it has not been updated for a while. This is just a way to keep the support issues queue manageable.
It will be closed soon unless the stale label is removed by a committer, or a new comment is made.

@github-actions github-actions bot added the stale label Oct 25, 2023
@karianna karianna removed the stale label Oct 25, 2023
Copy link

We are marking this issue as stale because it has not been updated for a while. This is just a way to keep the support issues queue manageable.
It will be closed soon unless the stale label is removed by a committer, or a new comment is made.

@github-actions github-actions bot added the stale label Jan 24, 2024
@karianna karianna removed the stale label Jan 24, 2024
@khourig
Copy link
Author

khourig commented Mar 4, 2024

Here is post that recommends using the VC redistributable installer.
https://stackoverflow.com/questions/74073045/is-it-ok-to-distribute-api-ms-win-core-xxx-dll-with-my-app

The redistributable installers:
https://learn.microsoft.com/en-US/cpp/windows/latest-supported-vc-redist

@karianna
Copy link
Contributor

karianna commented Mar 5, 2024

@andrew-m-leonard You might have an opinion on this and reproducible builds.

@andrew-m-leonard
Copy link

I don't think this is correct, the redist DLLs listed here: https://docs.microsoft.com/en-us/visualstudio/releases/2022/redistribution
is the "Visual Studio" redistribution list, not the UCRT list.
UCRT is not a direct part of Visual Studio, it is a Windows OS component and provided as part of the "Windows Kit" SDK.
As documented here the advice is to redist and copy all of C:\Program Files (x86)\Windows Kits\10\Redist\ucrt, (which is the complete set of api-ms-win*.dll's), which is what the OpenJDK make progress does.

@khourig
Copy link
Author

khourig commented Mar 14, 2024

Ok so a local copy of the api-ms DLLs for Windows 7 and older. An honest question: are those systems relevant? For my project, they are not. We will remove the api-ms DLLs from the jdk folder.

Copy link

We are marking this issue as stale because it has not been updated for a while. This is just a way to keep the support issues queue manageable.
It will be closed soon unless the stale label is removed by a committer, or a new comment is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale windows
Projects
None yet
Development

No branches or pull requests

4 participants