Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classNames, cellClassNames cannot be arrays #416

Open
buschtoens opened this issue Jun 1, 2017 · 0 comments
Open

classNames, cellClassNames cannot be arrays #416

buschtoens opened this issue Jun 1, 2017 · 0 comments

Comments

@buschtoens
Copy link
Collaborator

buschtoens commented Jun 1, 2017

https://github.com/offirgolan/ember-light-table/blob/v1.8.6/addon/classes/Column.js#L259-L265

  /**
   * Class names to be applied to all cells of this column
   *
   * @property cellClassNames
   * @type {String | Array}
   */
  cellClassNames: null,

https://github.com/offirgolan/ember-light-table/blob/v1.8.6/addon/components/cells/base.js#L15-L25

/**
 * @module Cell Types
 * @class Base Cell
 */

const Cell = Component.extend({
  layout,
  tagName: 'td',
  classNames: ['lt-cell'],
  attributeBindings: ['style'],
  classNameBindings: ['align', 'isSorted', 'column.cellClassNames'],
  // ..
});

The same goes for classNames.

When passed an array of class names, the array is stringified (concatenated with ,).

I'll submit a PR when I can get around to it. Merely putting this here for tracking. 🙂
Otherwise this would be a great PR for a first-time contributor! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants