fix(number-field): add support for scrubbing #4476
Open
+229
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
force-pushed
the
number-field/scrubber
branch
from
5db4275 to
a6280d7
Compare
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Westbrook
force-pushed
the
number-field/scrubber
branch
from
a6280d7 to
f123cbe
Compare
Tachometer resultsChromenumber-field permalinkbasic-test
slider permalinktest-basic
Firefoxnumber-field permalinkbasic-test
slider permalinktest-basic
|
Westbrook
force-pushed
the
number-field/scrubber
branch
from
f123cbe to
3034755
Compare
* feat(number-field): added features required for internal Adobe project - scrubbable (drag left/right for increment decrementing) - allow per pixel amount for scrubbing (defaults to using existing step) - shift modifier step multiplier for fast keyboard increment/decrement * feat(number-field): add shift modifier to multiply key input * feat(number-field): put stepper buttons in shift modifier path * fix(number-field): fix issue with PR where there are runtime errors when buttons are hidden * fix(number-field): add property to indicate that the user is scrubbing * fix(number-field): delay scrub input by 250ms in case user clicked/dragged a bit meaning to focus * fix(number-field): issue with scrubbing off component lights up focus ring without having focus * fix(number-field): issues with intermittent inner focus-visible and misfiring on negative distance
Westbrook
force-pushed
the
number-field/scrubber
branch
from
3034755 to
8fc67cc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This had been bopping around in a branch for a long while thanks to the work of @bengfarrell and I wanted to get it into a PR in case people were interested in adopting it.
Allow click and drag on the input of a Number Field to scrub the value.
Related issue(s)
How has this been tested?
Types of changes
Checklist