Skip to content

Commit f6b613f

Browse files
committed
refactor(field-label): use core tokens
This adds a beta version of the migrated-to-core-tokens FieldLabel component
1 parent ecc76a0 commit f6b613f

File tree

5 files changed

+134
-191
lines changed

5 files changed

+134
-191
lines changed

packages/field-label/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
"tslib": "^2.0.0"
6565
},
6666
"devDependencies": {
67-
"@spectrum-css/fieldlabel": "^4.0.29"
67+
"@spectrum-css/fieldlabel": "^5.0.0-beta.2"
6868
},
6969
"types": "./src/index.d.ts",
7070
"customElements": "custom-elements.json",

packages/field-label/src/spectrum-field-label.css

Lines changed: 122 additions & 176 deletions
Original file line numberDiff line numberDiff line change
@@ -12,234 +12,180 @@ governing permissions and limitations under the License.
1212

1313
/* THIS FILE IS MACHINE GENERATED. DO NOT EDIT */
1414
:host([size='s']) {
15-
--spectrum-fieldlabel-padding-top: var(
16-
--spectrum-fieldlabel-s-padding-top,
17-
var(--spectrum-global-dimension-size-50)
15+
--spectrum-fieldlabel-top-to-text: var(
16+
--spectrum-component-top-to-text-75
1817
); /* .spectrum-FieldLabel--sizeS */
19-
--spectrum-fieldlabel-padding-bottom: var(
20-
--spectrum-fieldlabel-s-padding-bottom,
21-
var(--spectrum-global-dimension-size-65)
18+
--spectrum-fieldlabel-bottom-to-text: var(
19+
--spectrum-component-bottom-to-text-75
2220
);
23-
--spectrum-fieldlabel-text-size: var(
24-
--spectrum-fieldlabel-s-text-size,
25-
var(--spectrum-global-dimension-font-size-75)
26-
);
27-
--spectrum-fieldlabel-text-font-weight: var(
28-
--spectrum-fieldlabel-s-text-font-weight,
29-
var(--spectrum-alias-body-text-font-weight)
21+
--spectrum-fieldlabel-font-size: var(--spectrum-font-size-75);
22+
--spectrum-fieldlabel-line-height: var(--spectrum-line-height-100);
23+
--spectrum-fieldlabel-cjk-line-height: var(--spectrum-CJK-line-height-100);
24+
--spectrum-fieldlabel-asterisk-gap: var(
25+
--spectrum-field-label-top-to-asterisk-small
3026
);
31-
--spectrum-fieldlabel-text-line-height: var(
32-
--spectrum-fieldlabel-s-text-line-height,
33-
var(--spectrum-alias-component-text-line-height)
27+
--spectrum-fieldlabel-side-padding-top: var(
28+
--spectrum-component-top-to-text-75
3429
);
35-
--spectrum-fieldlabel-asterisk-gap: var(
36-
--spectrum-fieldlabel-s-asterisk-gap,
37-
var(--spectrum-global-dimension-size-50)
30+
--spectrum-fieldlabel-side-padding-right: var(--spectrum-spacing-100);
31+
--spectrum-field-label-text-to-asterisk: var(
32+
--spectrum-field-label-text-to-asterisk-small
3833
);
3934
}
4035
:host([size='m']) {
41-
--spectrum-fieldlabel-padding-top: var(
42-
--spectrum-fieldlabel-m-padding-top,
43-
var(--spectrum-global-dimension-size-50)
36+
--spectrum-fieldlabel-top-to-text: var(
37+
--spectrum-component-top-to-text-75
4438
); /* .spectrum-FieldLabel--sizeM */
45-
--spectrum-fieldlabel-padding-bottom: var(
46-
--spectrum-fieldlabel-m-padding-bottom,
47-
var(--spectrum-global-dimension-size-65)
39+
--spectrum-fieldlabel-bottom-to-text: var(
40+
--spectrum-component-bottom-to-text-75
4841
);
49-
--spectrum-fieldlabel-text-size: var(
50-
--spectrum-fieldlabel-m-text-size,
51-
var(--spectrum-global-dimension-font-size-75)
42+
--spectrum-fieldlabel-font-size: var(--spectrum-font-size-75);
43+
--spectrum-fieldlabel-line-height: var(--spectrum-line-height-200);
44+
--spectrum-fieldlabel-cjk-line-height: var(--spectrum-CJK-line-height-200);
45+
--spectrum-fieldlabel-asterisk-gap: var(
46+
--spectrum-field-label-top-to-asterisk-medium
5247
);
53-
--spectrum-fieldlabel-text-font-weight: var(
54-
--spectrum-fieldlabel-m-text-font-weight,
55-
var(--spectrum-alias-body-text-font-weight)
48+
--spectrum-fieldlabel-side-padding-top: var(
49+
--spectrum-component-top-to-text-75
5650
);
57-
--spectrum-fieldlabel-text-line-height: var(
58-
--spectrum-fieldlabel-m-text-line-height,
59-
var(--spectrum-alias-component-text-line-height)
60-
);
61-
--spectrum-fieldlabel-asterisk-gap: var(
62-
--spectrum-fieldlabel-m-asterisk-gap,
63-
var(--spectrum-global-dimension-size-50)
51+
--spectrum-fieldlabel-side-padding-right: var(--spectrum-spacing-200);
52+
--spectrum-field-label-text-to-asterisk: var(
53+
--spectrum-field-label-text-to-asterisk-medium
6454
);
6555
}
6656
:host([size='l']) {
67-
--spectrum-fieldlabel-padding-top: var(
68-
--spectrum-fieldlabel-l-padding-top,
69-
var(--spectrum-global-dimension-size-75)
57+
--spectrum-fieldlabel-top-to-text: var(
58+
--spectrum-component-top-to-text-100
7059
); /* .spectrum-FieldLabel--sizeL */
71-
--spectrum-fieldlabel-padding-bottom: var(
72-
--spectrum-fieldlabel-l-padding-bottom,
73-
var(--spectrum-global-dimension-size-115)
74-
);
75-
--spectrum-fieldlabel-text-size: var(
76-
--spectrum-fieldlabel-l-text-size,
77-
var(--spectrum-global-dimension-font-size-100)
60+
--spectrum-fieldlabel-bottom-to-text: var(
61+
--spectrum-component-bottom-to-text-100
7862
);
79-
--spectrum-fieldlabel-text-font-weight: var(
80-
--spectrum-fieldlabel-l-text-font-weight,
81-
var(--spectrum-alias-body-text-font-weight)
63+
--spectrum-fieldlabel-font-size: var(--spectrum-font-size-100);
64+
--spectrum-fieldlabel-line-height: var(--spectrum-line-height-100);
65+
--spectrum-fieldlabel-cjk-line-height: var(--spectrum-CJK-line-height-100);
66+
--spectrum-fieldlabel-asterisk-gap: var(
67+
--spectrum-field-label-top-to-asterisk-large
8268
);
83-
--spectrum-fieldlabel-text-line-height: var(
84-
--spectrum-fieldlabel-l-text-line-height,
85-
var(--spectrum-alias-component-text-line-height)
69+
--spectrum-fieldlabel-side-padding-top: var(
70+
--spectrum-component-top-to-text-100
8671
);
87-
--spectrum-fieldlabel-asterisk-gap: var(
88-
--spectrum-fieldlabel-l-asterisk-gap,
89-
var(--spectrum-global-dimension-size-65)
72+
--spectrum-fieldlabel-side-padding-right: var(--spectrum-spacing-200);
73+
--spectrum-field-label-text-to-asterisk: var(
74+
--spectrum-field-label-text-to-asterisk-large
9075
);
9176
}
9277
:host([size='xl']) {
93-
--spectrum-fieldlabel-padding-top: var(
94-
--spectrum-fieldlabel-xl-padding-top,
95-
var(--spectrum-global-dimension-size-115)
78+
--spectrum-fieldlabel-top-to-text: var(
79+
--spectrum-component-top-to-text-200
9680
); /* .spectrum-FieldLabel--sizeXL */
97-
--spectrum-fieldlabel-padding-bottom: var(
98-
--spectrum-fieldlabel-xl-padding-bottom,
99-
var(--spectrum-global-dimension-size-130)
81+
--spectrum-fieldlabel-bottom-to-text: var(
82+
--spectrum-component-bottom-to-text-200
10083
);
101-
--spectrum-fieldlabel-text-size: var(
102-
--spectrum-fieldlabel-xl-text-size,
103-
var(--spectrum-global-dimension-font-size-200)
104-
);
105-
--spectrum-fieldlabel-text-font-weight: var(
106-
--spectrum-fieldlabel-xl-text-font-weight,
107-
var(--spectrum-alias-body-text-font-weight)
84+
--spectrum-fieldlabel-font-size: var(--spectrum-font-size-200);
85+
--spectrum-fieldlabel-line-height: var(--spectrum-line-height-200);
86+
--spectrum-fieldlabel-cjk-line-height: var(--spectrum-CJK-line-height-200);
87+
--spectrum-fieldlabel-asterisk-gap: var(
88+
--spectrum-field-label-top-to-asterisk-extra-large
10889
);
109-
--spectrum-fieldlabel-text-line-height: var(
110-
--spectrum-fieldlabel-xl-text-line-height,
111-
var(--spectrum-alias-component-text-line-height)
90+
--spectrum-fieldlabel-side-padding-top: var(
91+
--spectrum-component-top-to-text-200
11292
);
113-
--spectrum-fieldlabel-asterisk-gap: var(
114-
--spectrum-fieldlabel-xl-asterisk-gap,
115-
var(--spectrum-global-dimension-size-65)
93+
--spectrum-fieldlabel-side-padding-right: var(--spectrum-spacing-200);
94+
--spectrum-field-label-text-to-asterisk: var(
95+
--spectrum-field-label-text-to-asterisk-extra-large
11696
);
11797
}
11898
:host {
11999
-webkit-font-smoothing: subpixel-antialiased;
120100
-moz-osx-font-smoothing: auto;
121101
font-smoothing: subpixel-antialiased;
122102
box-sizing: border-box;
123-
display: block; /* .spectrum-FieldLabel,
124-
* .spectrum-Form-itemLabel */
125-
font-size: var(--spectrum-fieldlabel-text-size);
126-
font-weight: var(--spectrum-fieldlabel-text-font-weight);
127-
line-height: var(--spectrum-fieldlabel-text-line-height);
128-
padding-bottom: var(--spectrum-fieldlabel-padding-bottom);
129-
padding-left: 0;
130-
padding-right: 0;
131-
padding-top: var(--spectrum-fieldlabel-padding-top);
103+
display: block; /* .spectrum-FieldLabel */
104+
font-size: var(
105+
--mod-fieldlabel-font-size,
106+
var(--spectrum-fieldlabel-font-size)
107+
);
108+
font-weight: var(
109+
--mod-font-weight-regular,
110+
var(--spectrum-font-weight-regular)
111+
);
112+
line-height: var(
113+
--mod-fieldlabel-line-height,
114+
var(--spectrum-fieldlabel-line-height)
115+
);
116+
padding-block: var(--spectrum-fieldlabel-top-to-text)
117+
var(--spectrum-fieldlabel-bottom-to-text);
118+
padding-inline: 0;
132119
vertical-align: top;
133120
}
134-
:host([dir='ltr']) .required-icon {
135-
margin-left: var(
136-
--spectrum-fieldlabel-asterisk-gap
137-
); /* [dir=ltr] .spectrum-FieldLabel-requiredIcon */
138-
margin-right: 0;
139-
}
140-
:host([dir='rtl']) .required-icon {
141-
margin-left: 0;
142-
margin-right: var(
143-
--spectrum-fieldlabel-asterisk-gap
144-
); /* [dir=rtl] .spectrum-FieldLabel-requiredIcon */
121+
:host(:lang(ja)),
122+
:host(:lang(ko)),
123+
:host(:lang(zh)) {
124+
line-height: var(
125+
--mod-fieldlabel-CJK-line-height,
126+
var(--spectrum-fieldlabel-cjk-line-height)
127+
); /* .spectrum-FieldLabel:lang(ja),
128+
* .spectrum-FieldLabel:lang(zh),
129+
* .spectrum-FieldLabel:lang(ko) */
145130
}
146131
.required-icon {
147-
margin-bottom: 0;
148-
margin-top: 0; /* .spectrum-FieldLabel-requiredIcon */
149-
}
150-
:host([dir='ltr'][side-aligned='start']) {
151-
padding-left: 0; /* [dir=ltr] .spectrum-FieldLabel--left */
152-
padding-right: var(
153-
--spectrum-fieldlabel-m-side-padding-right,
154-
var(--spectrum-global-dimension-size-150)
155-
);
156-
}
157-
:host([dir='rtl'][side-aligned='start']) {
158-
padding-left: var(
159-
--spectrum-fieldlabel-m-side-padding-right,
160-
var(--spectrum-global-dimension-size-150)
161-
);
162-
padding-right: 0; /* [dir=rtl] .spectrum-FieldLabel--left */
132+
margin-block: 0; /* .spectrum-FieldLabel-requiredIcon */
133+
margin-inline: var(
134+
--mod-fieldlabel-asterisk-gap,
135+
var(--spectrum-fieldlabel-asterisk-gap)
136+
)
137+
0;
163138
}
164139
:host([side-aligned='start']) {
165140
display: inline-block; /* .spectrum-FieldLabel--left */
166-
padding-bottom: 0;
167-
padding-top: var(
168-
--spectrum-fieldlabel-m-side-padding-top,
169-
var(--spectrum-global-dimension-size-100)
170-
);
171-
}
172-
:host([dir='ltr'][side-aligned='start']) .required-icon {
173-
margin-left: var(
174-
--spectrum-fieldlabel-asterisk-gap
175-
); /* [dir=ltr] .spectrum-FieldLabel--left .spectrum-FieldLabel-requiredIcon */
176-
margin-right: 0;
177-
}
178-
:host([dir='rtl'][side-aligned='start']) .required-icon {
179-
margin-left: 0;
180-
margin-right: var(
181-
--spectrum-fieldlabel-asterisk-gap
182-
); /* [dir=rtl] .spectrum-FieldLabel--left .spectrum-FieldLabel-requiredIcon */
141+
padding-block: var(
142+
--mod-fieldlabel-side-padding-top,
143+
var(--spectrum-fieldlabel-side-padding-top)
144+
)
145+
0;
146+
padding-inline: 0
147+
var(
148+
--mod-fieldlabel-side-padding-right,
149+
var(--spectrum-fieldlabel-side-padding-right)
150+
);
183151
}
184152
:host([side-aligned='start']) .required-icon {
185-
margin-bottom: 0;
186-
margin-top: var(
187-
--spectrum-fieldlabel-m-side-asterisk-margin-y,
188-
var(--spectrum-global-dimension-size-100)
189-
); /* .spectrum-FieldLabel--left .spectrum-FieldLabel-requiredIcon */
190-
}
191-
:host([dir='ltr'][side-aligned='end']) {
192-
text-align: right; /* [dir=ltr] .spectrum-FieldLabel--right */
193-
}
194-
:host([dir='rtl'][side-aligned='end']) {
195-
text-align: left; /* [dir=rtl] .spectrum-FieldLabel--right */
196-
}
197-
:host([dir='ltr'][side-aligned='end']) {
198-
padding-left: 0; /* [dir=ltr] .spectrum-FieldLabel--right */
199-
padding-right: var(
200-
--spectrum-fieldlabel-m-side-padding-right,
201-
var(--spectrum-global-dimension-size-150)
202-
);
203-
}
204-
:host([dir='rtl'][side-aligned='end']) {
205-
padding-left: var(
206-
--spectrum-fieldlabel-m-side-padding-right,
207-
var(--spectrum-global-dimension-size-150)
208-
);
209-
padding-right: 0; /* [dir=rtl] .spectrum-FieldLabel--right */
153+
margin-block: var(
154+
--mod-field-label-text-to-asterisk,
155+
var(--spectrum-field-label-text-to-asterisk)
156+
)
157+
0; /* .spectrum-FieldLabel--left .spectrum-FieldLabel-requiredIcon */
158+
margin-inline: var(
159+
--mod-fieldlabel-asterisk-gap,
160+
var(--spectrum-fieldlabel-asterisk-gap)
161+
)
162+
0;
210163
}
211164
:host([side-aligned='end']) {
212165
display: inline-block; /* .spectrum-FieldLabel--right */
213-
padding-bottom: 0;
214-
padding-top: var(
215-
--spectrum-fieldlabel-m-side-padding-top,
216-
var(--spectrum-global-dimension-size-100)
217-
);
218-
}
219-
:host {
220-
color: var(
221-
--spectrum-fieldlabel-m-text-color,
222-
var(--spectrum-alias-label-text-color)
223-
); /* .spectrum-FieldLabel,
224-
* .spectrum-Form-itemLabel */
166+
padding-block: var(
167+
--mod-fieldlabel-side-padding-top,
168+
var(--spectrum-fieldlabel-side-padding-top)
169+
)
170+
0;
171+
padding-inline: 0
172+
var(
173+
--mod-fieldlabel-side-padding-right,
174+
var(--spectrum-fieldlabel-side-padding-right)
175+
);
176+
text-align: end;
225177
}
226178
:host([disabled]) {
227179
color: var(
228-
--spectrum-fieldlabel-m-text-color-disabled,
229-
var(--spectrum-alias-text-color-disabled)
180+
--mod-disabled-content-color,
181+
var(--spectrum-disabled-content-color)
230182
); /* .spectrum-FieldLabel.is-disabled,
231183
* .spectrum-Form-itemLabel.is-disabled */
232184
}
233185
:host([disabled]) .required-icon {
234186
color: var(
235-
--spectrum-fieldlabel-m-asterisk-color-disabled,
236-
var(--spectrum-alias-text-color-disabled)
187+
--mod-disabled-content-color,
188+
var(--spectrum-disabled-content-color)
237189
); /* .spectrum-FieldLabel.is-disabled .spectrum-FieldLabel-requiredIcon,
238190
* .spectrum-Form-itemLabel.is-disabled .spectrum-FieldLabel-requiredIcon */
239191
}
240-
.required-icon {
241-
color: var(
242-
--spectrum-fieldlabel-m-asterisk-color,
243-
var(--spectrum-global-color-gray-600)
244-
); /* .spectrum-FieldLabel-requiredIcon */
245-
}

packages/styles/express/core-global.css

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3303,15 +3303,6 @@ governing permissions and limitations under the License.
33033303
--spectrum-slider-label-text-size: var(
33043304
--spectrum-global-dimension-font-size-100
33053305
);
3306-
--spectrum-fieldlabel-s-text-size: var(
3307-
--spectrum-global-dimension-font-size-100
3308-
);
3309-
--spectrum-fieldlabel-m-text-size: var(
3310-
--spectrum-global-dimension-font-size-100
3311-
);
3312-
--spectrum-fieldlabel-l-text-size: var(
3313-
--spectrum-global-dimension-font-size-200
3314-
);
33153306
--spectrum-fieldlabel-xl-text-size: var(
33163307
--spectrum-global-dimension-font-size-300
33173308
);

scripts/spectrum-tokens.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,13 @@ const tokensRoot = path.join(
2929
'*.css'
3030
);
3131

32-
const tokenPackages = ['actionbutton', 'closebutton', 'helptext', 'radio'];
32+
const tokenPackages = [
33+
'actionbutton',
34+
'closebutton',
35+
'helptext',
36+
'radio',
37+
'fieldlabel',
38+
];
3339

3440
const packagePaths = tokenPackages.map((packageName) => {
3541
return path.join(

0 commit comments

Comments
 (0)