Skip to content

Spectrum tokens 17 - Textfield Textarea #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Sep 22, 2020

Description

How and where has this been tested?

  • Browser(s) and OS(s) this was tested with: Tested in latest Chrome

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@GarthDB
Copy link
Member Author

GarthDB commented Sep 22, 2020

Looks like I have an issue with the icon placement on the quiet variants. I'll fix that.

Copy link
Member

@lazd lazd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the padding -> inset change, was that a mistake?

@jianliao jianliao mentioned this pull request Sep 22, 2020
3 tasks
@jianliao
Copy link
Contributor

@GarthDB VRT result is here

But I don't know why spectrum-github-bot could not post the comment here.

@GarthDB
Copy link
Member Author

GarthDB commented Sep 22, 2020

So the VRT shows a change in the quiet textfield/textarea, but the VRT is not in sync with the DL UI kit. From the UI kit:
image

While this is the VRT reference:
image

It shouldn't have the side padding. So this PR is ready to go.

@bernhard-adobe
Copy link
Contributor

This looks good to me, we had to do the same update in the SVG-Generator. I think it also fixes a bug where the green checkmark validation icon was gray and now is green. Maybe worth double checking.

@bernhard-adobe bernhard-adobe merged commit 99e11eb into spectrum-tokens-17 Sep 22, 2020
@GarthDB GarthDB deleted the spectrum-tokens-17-textfield branch September 22, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants