Skip to content

Spectrum tokens 17 dial #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2020
Merged

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Aug 31, 2020

Description

  • Separated Dial from Slider to align with DNA organization.
  • Removed Slider tokens from Dial.
  • Removed deprecated tokens.

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with: Chrome 84.0.4147.135 (Official Build) (64-bit) MacOS

Screenshots

image

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@GarthDB GarthDB added this to the Token Deprecation milestone Aug 31, 2020
@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

Copy link
Contributor

@jianliao jianliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@jianliao jianliao merged commit d4e0db5 into spectrum-tokens-17 Sep 8, 2020
@GarthDB GarthDB deleted the spectrum-tokens-17-dial branch September 23, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants