-
Notifications
You must be signed in to change notification settings - Fork 202
feat(icon, ui-icons): add missing ui icons and sizing classes #3866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rise-erpelding
merged 4 commits into
spectrum-two
from
rise-erpelding/css-1194-new-ui-icons
May 29, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4873b91
feat(icon): add new ui icon tokens and classes to ui-icons.css
rise-erpelding 6239f66
feat(icon): re-add removed icon files
rise-erpelding a325988
chore(icon): remove additional sort fn
rise-erpelding 69b8f90
chore(ui-icons, icon): changeset
rise-erpelding File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@spectrum-css/icon": minor | ||
--- | ||
|
||
Updates the icon component to use size tokens for newly added ui icons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
--- | ||
"@spectrum-css/ui-icons": minor | ||
--- | ||
|
||
Makes updates to the initial S2 icons update to include some additional icons with names as follows: | ||
|
||
| Icon name | | ||
| ----------------- | | ||
| Add50 | | ||
| Add75 | | ||
| Add100 | | ||
| Add200 | | ||
| Add300 | | ||
| DragHandle75 | | ||
| DragHandle100 | | ||
| DragHandle200 | | ||
| DragHandle300 | | ||
| Gripper100 | | ||
| LinkOut100 | | ||
| LinkOut200 | | ||
| LinkOut300 | | ||
| LinkOut400 | | ||
|
||
Such that the full set of changes for Spectrum 2 is as follows: | ||
|
||
| Icon name | Migration notes | | ||
| ----------------- | --------------- | | ||
| Add50 | **New** | | ||
| Add75 | **New** | | ||
| Add100 | **New** | | ||
| Add200 | **New** | | ||
| Add300 | **New** | | ||
| Arrow75 | Deprecated | | ||
| Arrow100 | - | | ||
| Arrow200 | Deprecated | | ||
| Arrow300 | Deprecated | | ||
| Arrow400 | - | | ||
| Arrow500 | Deprecated | | ||
| Arrow600 | Deprecated | | ||
| Asterisk75 | Deprecated | | ||
| Asterisk100 | - | | ||
| Asterisk200 | - | | ||
| Asterisk300 | - | | ||
| Checkmark50 | - | | ||
| Checkmark75 | - | | ||
| Checkmark100 | - | | ||
| Checkmark200 | - | | ||
| Checkmark300 | - | | ||
| Checkmark400 | - | | ||
| Checkmark500 | Deprecated | | ||
| Checkmark600 | Deprecated | | ||
| Chevron50 | - | | ||
| Chevron75 | - | | ||
| Chevron100 | - | | ||
| Chevron200 | - | | ||
| Chevron300 | - | | ||
| Chevron400 | - | | ||
| Chevron500 | Deprecated | | ||
| Chevron600 | Deprecated | | ||
| CornerTriangle75 | - | | ||
| CornerTriangle100 | - | | ||
| CornerTriangle200 | - | | ||
| CornerTriangle300 | - | | ||
| Cross75 | - | | ||
| Cross100 | - | | ||
| Cross200 | - | | ||
| Cross300 | - | | ||
| Cross400 | - | | ||
| Cross500 | - | | ||
| Cross600 | - | | ||
| Dash50 | - | | ||
| Dash75 | - | | ||
| Dash100 | - | | ||
| Dash200 | - | | ||
| Dash300 | - | | ||
| Dash400 | Deprecated | | ||
| Dash500 | Deprecated | | ||
| Dash600 | Deprecated | | ||
| DragHandle75 | **New** | | ||
| DragHandle100 | **New** | | ||
| DragHandle200 | **New** | | ||
| DragHandle300 | **New** | | ||
| Gripper100 | **New** | | ||
| SingleGripper | Deprecated | | ||
| DoubleGripper | Deprecated | | ||
| TripleGripper | Deprecated | | ||
| LinkOut100 | **New** | | ||
| LinkOut200 | **New** | | ||
| LinkOut300 | **New** | | ||
| LinkOut400 | **New** | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these two were already being sorted in a way that separates the icon name and numerical size (in
components/icon/stories/utilities.js
), so adding.sort()
here was reverting the sorted icons list back to ASCII order (so thatAdd100
appears beforeAdd50
, for instance).