Skip to content

chore: add missing tags #3692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marissahuysentruyt
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt commented May 6, 2025

Description

This is a copy of #3688. The commit doesn't seem to be on the spectrum-two branch, even though that branch was merged.

Some of our migrated components from 2024 (like textfield, search, switch, button, etc), had the migrated tag added to the components' metadata. You could find tags: ["migrated"] in the story files. However, at some point we stopped adding that tag, and because we've gotten back to migrated S2 components, it would probably be good to add this tag to all of our currently migrated components.

This work adds that migrated tag to the components that are missing it as of 5 May 2025.

Jira

CSS-1191 (ticket for this work)
CSS-604 (epic for S2 Migration)

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Pull down the branch to be able search.
  • Search for tags: ["migrated"] in the repo. You should get 45 components returned 🥳
  • Compare the results to the list in the S2 Migration epic. All components found during your search should have an associated ticket, EXCEPT FOR:
    • The progress bar ticket looks like it's missing from the epic, but it was migrated here: feat(progressbar): s2 migration #2659 👍
    • The status light ticket looks like it's missing from the epic, but it was migrated here: feat(statuslight): s2 migration #2818 👍
    • The switch ticket looks like it's missing from the epic, but it was migrated here: feat(switch): s2 migration #2651 👍
    • The dial component is marked as migrated, but I believe this is a "one-off" component. There are no designs. 👍
    • The field group component is marked as migrated, probably because that component is just collections of checkboxes and collections of radios (both of which have been migrated). 👍
    • The form component is marked as migrated for a similar reason. All nested components in the form, aside from number field (which is in-progress), have been migrated. 👍
    • Pagination is marked as migrated for a similar reason. All nested components have been migrated. 👍

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented May 6, 2025

🦋 Changeset detected

Latest commit: 9617548

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@spectrum-css/inlinealert Major
@spectrum-css/rating Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marissahuysentruyt marissahuysentruyt changed the base branch from main to spectrum-two May 6, 2025 15:18
@marissahuysentruyt marissahuysentruyt marked this pull request as ready for review May 6, 2025 15:21
@marissahuysentruyt marissahuysentruyt self-assigned this May 6, 2025
@marissahuysentruyt marissahuysentruyt added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review S2 Spectrum 2 labels May 6, 2025
Copy link
Contributor

github-actions bot commented May 6, 2025

🚀 Deployed on https://pr-3692--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented May 6, 2025

File metrics

Summary

Total size: 1.38 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@marissahuysentruyt marissahuysentruyt merged commit 6bd6641 into spectrum-two May 6, 2025
17 of 24 checks passed
@marissahuysentruyt marissahuysentruyt deleted the marissahuysentruyt/docs-add-missing-tags branch May 6, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review S2 Spectrum 2 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants