-
Notifications
You must be signed in to change notification settings - Fork 202
feat(menu): spectrum 2 migration #3686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
a3f0d48
feat(menu): initial token updates
5t3ph 5910e48
feat(menu): move description, thumbnail, linkout styles
5t3ph 0004133
feat(menu): remove incorrectly added tokens
5t3ph 622a285
chore(tokens): use spectrum-tokens@13.0.0
5t3ph 2e4a280
feat(menu): resolve styles from tokens package update
5t3ph a0d1015
feat(menu): thumbnail and linkout markup
5t3ph 658a82b
chore(*): merge branch 'spectrum-two' of https://github.com/adobe/spe…
5t3ph 8c1983c
feat(menu): background-color and focus-indicator tokens
5t3ph cd7a3c1
feat(menu): update workflow icon names
5t3ph d35054a
feat(menu): incorporate section heading, resolve alignment
5t3ph 3bcbe9e
feat(menu): extend stories to new features
5t3ph 473a44a
feat(menu): update tests with new features
5t3ph 6ecca60
feat(menu): alignment improvements
5t3ph a904129
feat(menu): resolve grid template spacing
5t3ph 8952e1d
chore(*): merge branch 'spectrum-two' of https://github.com/adobe/spe…
5t3ph 336b8bb
feat(menu): update metadata
5t3ph 7bd21da
chore(*): revert accidental merge changes
5t3ph e46ec98
feat(menu): cleanup
5t3ph 83648d9
feat(menu): add back background tokens
5t3ph ed988bc
feat(menu): add changelog
5t3ph df935af
feat(menu): resolve truncation examples
5t3ph f0541ac
chore(*): merge branch 'spectrum-two' of https://github.com/adobe/spe…
5t3ph a6aa9f4
chore(*): resolve metadata updates
5t3ph a8357a3
chore(*): revert merge changes
5t3ph af5aa51
chore(*): revert merge changes
5t3ph 67dacaa
feat(menu): add mod, correct sizing tokens, story updates
5t3ph 417a518
feat(menu): down state, token/selector corrections
5t3ph 9ede99a
chore(*): merge branch 'spectrum-two' of https://github.com/adobe/spe…
5t3ph File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
--- | ||
"@spectrum-css/menu": major | ||
--- | ||
|
||
### Spectrum 2 migration | ||
|
||
Menu now uses Spectrum 2 tokens and specifications. | ||
|
||
Removes custom menu item background color tokens: `@adobe/spectrum-tokens` has been updated to include many tokens relating to the menu component, including some that replace custom tokens that had previously been added. As such, these custom menu item color tokens that are now available from `@adobe/spectrum-tokens` have been removed. | ||
|
||
In addition to other small token and minor style changes, there were several new features that were added to this version of menu, including: | ||
|
||
- A thumbnail can now be used in place of an icon | ||
- A section description can now be included below the menu section heading | ||
- The actions area previously held action switches for multi-select, and in this version, an external link action icon can be included in that area | ||
|
||
### New mods | ||
|
||
- `--mod-menu-item-corner-radius` | ||
- `--mod-menu-item-linkout-icon-height` | ||
- `--mod-menu-item-linkout-icon-width` | ||
- `--mod-menu-item-thumbnail-height` | ||
- `--mod-menu-item-thumbnail-opacity-disabled` | ||
- `--mod-menu-item-thumbnail-to-label` | ||
- `--mod-menu-item-thumbnail-width` | ||
- `--mod-menu-item-top-to-thumbnail` | ||
- `--mod-menu-item-top-to-workflow-icon` | ||
- `--mod-menu-section-description-color` | ||
- `--mod-menu-section-description-font-size` | ||
- `--mod-menu-section-description-font-weight` | ||
- `--mod-menu-section-description-line-height` | ||
- `--mod-menu-section-description-line-height-cjk` | ||
- `--mod-menu-section-header-to-description` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.