-
Notifications
You must be signed in to change notification settings - Fork 201
feat(tag): migrate to S2 #3682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rise-erpelding
wants to merge
13
commits into
spectrum-two
Choose a base branch
from
rise-erpelding/tag-s2-pt2
base: spectrum-two
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+589
−591
Open
feat(tag): migrate to S2 #3682
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
066cf3b
feat(tag): s2 token migration
rise-erpelding fbcb145
test(tag): set up testing grid
rise-erpelding d11ac3e
docs(tag): update storybook for s2
rise-erpelding 0237341
chore(tag): metadata
rise-erpelding b6c5a2e
chore(tag): changeset
rise-erpelding e1a8bdb
docs(tag): template adjustments
rise-erpelding 61f91d0
fix(tag): the easier pr fixes
rise-erpelding 361cf27
fix(tag): make small tag's default size
rise-erpelding 4e6ce7b
fix(tag): assorted pr fixes
rise-erpelding 7bef22a
fix(tag): adjust clear button spacing
rise-erpelding 7094320
fix(tag): expand clear button target area
rise-erpelding 9624755
refactor(tag): redefine custom props for variants
rise-erpelding 775c221
chore(tag): update changeset
rise-erpelding File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| --- | ||
| "@spectrum-css/tag": major | ||
| --- | ||
|
|
||
| Tag now uses Spectrum 2 tokens and specifications: | ||
|
|
||
| - The invalid variant has been removed. | ||
| - Borders remain in high contrast but are otherwise transparent. | ||
| - Thumbnail has been added as a visual option. | ||
| - Tag now has a max-inline-size. | ||
| - Read-only tags are now supported. | ||
| - Passthroughs for clear button have been updated to match the current spec. | ||
| - Default t-shirt size for tag is small. | ||
| - Clear button has accessibly sized target. | ||
| - Emphasized tags have accent coloring only when they are selected. | ||
|
|
||
| Changed mods: | ||
|
|
||
| - "--mod-tag-avatar-spacing-inline-end" --> "--mod-tag-visual-spacing-inline-end", | ||
| - "--mod-tag-icon-spacing-inline-end" --> "--mod-tag-visual-spacing-inline-end", | ||
| - "--mod-tag-spacing-inline-start" --> "--mod-tag-label-spacing-inline", | ||
| - "--mod-tag-label-spacing-inline-end" --> "--mod-tag-label-spacing-inline" | ||
| - "--mod-tag-clear-button-spacing-inline-start" --> "--mod-tag-label-to-clear-icon", | ||
| - "--mod-tag-clear-button-spacing-inline-end" --> "--mod-tag-edge-to-clear-icon" | ||
|
|
||
| Added mods: | ||
|
|
||
| - "--mod-tag-avatar-size", | ||
| - "--mod-tag-clear-button-size", | ||
| - "--mod-tag-label-font-family", | ||
| - "--mod-tag-label-font-style", | ||
| - "--mod-tag-label-line-height-cjk", | ||
| - "--mod-tag-maximum-width-multiplier", | ||
| - "--mod-tag-min-inline-size", | ||
| - "--mod-tag-thumbnail-size", | ||
| - "--mod-tag-visual-spacing-inline-start" | ||
|
|
||
| Removed mods: | ||
|
|
||
| - "--mod-tag-background-color-invalid-selected", | ||
| - "--mod-tag-background-color-invalid-selected-active", | ||
| - "--mod-tag-background-color-invalid-selected-focus", | ||
| - "--mod-tag-background-color-invalid-selected-hover", | ||
| - "--mod-tag-border-color-emphasized-active", | ||
| - "--mod-tag-border-color-emphasized-focus", | ||
| - "--mod-tag-border-color-emphasized-hover", | ||
| - "--mod-tag-border-color-invalid", | ||
| - "--mod-tag-border-color-invalid-active", | ||
| - "--mod-tag-border-color-invalid-focus", | ||
| - "--mod-tag-border-color-invalid-hover", | ||
| - "--mod-tag-border-color-invalid-selected", | ||
| - "--mod-tag-border-color-invalid-selected-active", | ||
| - "--mod-tag-border-color-invalid-selected-focus", | ||
| - "--mod-tag-border-color-invalid-selected-hover", | ||
| - "--mod-tag-border-color-selected-active", | ||
| - "--mod-tag-border-color-selected-focus", | ||
| - "--mod-tag-border-color-selected-hover", | ||
| - "--mod-tag-content-color-invalid", | ||
| - "--mod-tag-content-color-invalid-active", | ||
| - "--mod-tag-content-color-invalid-focus", | ||
| - "--mod-tag-content-color-invalid-hover", | ||
| - "--mod-tag-content-color-invalid-selected", | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add it's been removed because there are no individual invalid tags and errors are displayed in tag groups.