Skip to content

test(combobox): corrects cases where open combobox stories and testing previews could overlap adjacent components #3568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Feb 20, 2025

Description

CSS-1132

Fixes spacing for open combobox tests and stories.

  • Adds fixes size to parameters.docs.story in combobox story file.
  • Adds min-inline-block-size to wrapperStyles for open stories.

Validation steps

  1. Open the branch preview.
  2. Navigate to the combobox docs.
  3. Verify that open component variations do not overlap adjacent components.
  4. Open the combobox component and enable the testing preview view.
  5. Verify that open component variations do not overlap adjacent components.

Screenshots

Screenshot 2025-02-20 at 10 02 14 AM

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Feb 20, 2025
@cdransf cdransf self-assigned this Feb 20, 2025
Copy link

changeset-bot bot commented Feb 20, 2025

⚠️ No Changeset found

Latest commit: ae81ba8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cdransf cdransf changed the base branch from main to spectrum-two February 20, 2025 21:33
@cdransf cdransf closed this Feb 20, 2025
@cdransf cdransf reopened this Feb 20, 2025
Copy link
Contributor

github-actions bot commented Feb 20, 2025

File metrics

Summary

Total size: 1.42 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Feb 20, 2025

🚀 Deployed on https://pr-3568--spectrum-css.netlify.app

@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT and removed skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Feb 21, 2025
@castastrophe castastrophe changed the title fix(combobox): corrects cases where open combobx stories and testing previews could overlap adjacent components test(combobox): corrects cases where open combobox stories and testing previews could overlap adjacent components Feb 21, 2025
@cdransf cdransf force-pushed the cdransf/fix-combobox-test-stories branch from 73ddd53 to ae81ba8 Compare February 21, 2025 17:05
@cdransf cdransf requested a review from castastrophe February 21, 2025 17:05
@castastrophe castastrophe merged commit 95af748 into spectrum-two Feb 21, 2025
14 checks passed
@castastrophe castastrophe deleted the cdransf/fix-combobox-test-stories branch February 21, 2025 21:25
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
castastrophe pushed a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review run_vrt For use on PRs looking to kick off VRT size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants