Skip to content

fix: resolve s2 branch build errors #3525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

jawinn
Copy link
Collaborator

@jawinn jawinn commented Jan 28, 2025

Description

  • Resolves linting error in opacitycheckerboard: 'size' is assigned a value but never used no-unused-vars

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • yarn linter opacitycheckerboard no longer shows the error 'size' is assigned a value but never used

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • ✨ This pull request is ready to merge. ✨

Resolves linting error:
'size' is assigned a value but never used  no-unused-vars
Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 430c7f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 28, 2025

🚀 Deployed on https://pr-3525--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Jan 28, 2025

File metrics

Summary

Total size: 2.22 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@jawinn jawinn marked this pull request as ready for review January 28, 2025 22:16
@jawinn jawinn added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. ready-for-review labels Jan 28, 2025
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me- no lint errors 👍

@castastrophe castastrophe merged commit a9e5b10 into spectrum-two Jan 29, 2025
27 of 35 checks passed
@castastrophe castastrophe deleted the jawinn/fix-s2-build-error branch January 29, 2025 14:54
jawinn added a commit that referenced this pull request Feb 3, 2025
Resolves linting error:
'size' is assigned a value but never used  no-unused-vars
castastrophe pushed a commit that referenced this pull request Feb 5, 2025
Resolves linting error:
'size' is assigned a value but never used  no-unused-vars
pfulton pushed a commit that referenced this pull request Feb 6, 2025
Resolves linting error:
'size' is assigned a value but never used  no-unused-vars
castastrophe pushed a commit that referenced this pull request Feb 7, 2025
Resolves linting error:
'size' is assigned a value but never used  no-unused-vars
castastrophe pushed a commit that referenced this pull request Feb 7, 2025
Resolves linting error:
'size' is assigned a value but never used  no-unused-vars
castastrophe pushed a commit that referenced this pull request Feb 7, 2025
Resolves linting error:
'size' is assigned a value but never used  no-unused-vars
castastrophe pushed a commit that referenced this pull request Feb 11, 2025
Resolves linting error:
'size' is assigned a value but never used  no-unused-vars
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
Resolves linting error:
'size' is assigned a value but never used  no-unused-vars
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
Resolves linting error:
'size' is assigned a value but never used  no-unused-vars
castastrophe pushed a commit that referenced this pull request Feb 25, 2025
Resolves linting error:
'size' is assigned a value but never used  no-unused-vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants