Skip to content

fix(*): define missing custom properties from theme directory #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 21, 2025
Merged

fix(*): define missing custom properties from theme directory #3517

merged 14 commits into from
Jan 21, 2025

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Jan 21, 2025

Description

CSS-1084

  • fixes missing custom properties by transferring them from s2-foundations-redux

image
image

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 599fcc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@spectrum-css/infieldbutton Patch
@spectrum-css/actionbutton Patch
@spectrum-css/clearbutton Patch
@spectrum-css/avatar Patch
@spectrum-css/button Patch
@spectrum-css/dialog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cdransf cdransf force-pushed the cdransf/undefined-token-fixes-css-1084-redux branch from 599fcc0 to 29a01a9 Compare January 21, 2025 20:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

File metrics

Summary

Total size: 2.23 MB*
Total change (Δ): 🔴 ⬆ 2.81 KB (0.12%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
actionbutton 23.50 KB 🔴 ⬆ 1.08 KB
avatar 6.52 KB 🟢 ⬇ 0.05 KB
button 30.25 KB 🔴 ⬆ 0.23 KB
clearbutton 6.18 KB 🔴 ⬆ 0.57 KB
dialog 15.00 KB 🟢 ⬇ 0.05 KB
infieldbutton 15.55 KB 🔴 ⬆ 0.79 KB

Details

actionbutton

Filename Head Compared to base
index.css 23.50 KB 🔴 ⬆ 1.08 KB (4.84%)
metadata.json 10.64 KB 🔴 ⬆ 0.14 KB (1.29%)

avatar

Filename Head Compared to base
index.css 6.52 KB 🟢 ⬇ 0.05 KB (-0.76%)
metadata.json 2.52 KB 🟢 ⬇ 0.06 KB (-2.27%)

button

Filename Head Compared to base
index.css 30.25 KB 🔴 ⬆ 0.23 KB (0.76%)
metadata.json 11.45 KB -

clearbutton

Filename Head Compared to base
index.css 6.18 KB 🔴 ⬆ 0.57 KB (9.93%)
metadata.json 3.35 KB 🔴 ⬆ 0.08 KB (2.39%)

dialog

Filename Head Compared to base
index.css 15.00 KB 🟢 ⬇ 0.05 KB (-0.32%)
metadata.json 5.66 KB 🟢 ⬇ 0.04 KB (-0.77%)

infieldbutton

Filename Head Compared to base
index.css 15.55 KB 🔴 ⬆ 0.79 KB (5.25%)
metadata.json 7.22 KB 🔴 ⬆ 0.15 KB (2.09%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://pr-3517--spectrum-css.netlify.app

@cdransf cdransf merged commit 7582c1f into spectrum-two Jan 21, 2025
11 checks passed
@cdransf cdransf deleted the cdransf/undefined-token-fixes-css-1084-redux branch January 21, 2025 21:48
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Merged
castastrophe pushed a commit that referenced this pull request Jan 22, 2025
@cdransf @castastrophe
fix(*): define missing custom properties from theme directory (#3517)
d940bb7 
* fix(*): define missing custom properties from theme directory

* fix(*): restore missing mods and tokens

* fix(*): restore missing mod and update metadata

* fix(*): restore missing mods and update metadata

* fix(*): restore basebutton import

* chore(*): update metadata

This reverts commit 3d489fe.

* fix(*): restore actionbutton staticwhite background color

* chore(*): update metadata

* chore: resolve conflict

* fix(*): actionbutton emphasized + static conflict

* fix(*): actionbutton restore missing mods

* fix(*): actionbutton clean up mods; fix missing states

* fix(*): actionbutton restore focus indicator mods

* chore(*): remove unused theme files
castastrophe pushed a commit that referenced this pull request Feb 5, 2025
@cdransf @castastrophe
fix(*): define missing custom properties from theme directory (#3517)
5065222 
* fix(*): define missing custom properties from theme directory

* fix(*): restore missing mods and tokens

* fix(*): restore missing mod and update metadata

* fix(*): restore missing mods and update metadata

* fix(*): restore basebutton import

* chore(*): update metadata

This reverts commit 3d489fe.

* fix(*): restore actionbutton staticwhite background color

* chore(*): update metadata

* chore: resolve conflict

* fix(*): actionbutton emphasized + static conflict

* fix(*): actionbutton restore missing mods

* fix(*): actionbutton clean up mods; fix missing states

* fix(*): actionbutton restore focus indicator mods

* chore(*): remove unused theme files
castastrophe pushed a commit that referenced this pull request Feb 7, 2025
@cdransf @castastrophe
fix(*): define missing custom properties from theme directory (#3517)
a398ad9 
* fix(*): define missing custom properties from theme directory

* fix(*): restore missing mods and tokens

* fix(*): restore missing mod and update metadata

* fix(*): restore missing mods and update metadata

* fix(*): restore basebutton import

* chore(*): update metadata

This reverts commit 3d489fe.

* fix(*): restore actionbutton staticwhite background color

* chore(*): update metadata

* chore: resolve conflict

* fix(*): actionbutton emphasized + static conflict

* fix(*): actionbutton restore missing mods

* fix(*): actionbutton clean up mods; fix missing states

* fix(*): actionbutton restore focus indicator mods

* chore(*): remove unused theme files
castastrophe pushed a commit that referenced this pull request Feb 7, 2025
@cdransf @castastrophe
fix(*): define missing custom properties from theme directory (#3517)
404e89d 
* fix(*): define missing custom properties from theme directory

* fix(*): restore missing mods and tokens

* fix(*): restore missing mod and update metadata

* fix(*): restore missing mods and update metadata

* fix(*): restore basebutton import

* chore(*): update metadata

This reverts commit 3d489fe.

* fix(*): restore actionbutton staticwhite background color

* chore(*): update metadata

* chore: resolve conflict

* fix(*): actionbutton emphasized + static conflict

* fix(*): actionbutton restore missing mods

* fix(*): actionbutton clean up mods; fix missing states

* fix(*): actionbutton restore focus indicator mods

* chore(*): remove unused theme files
castastrophe pushed a commit that referenced this pull request Feb 7, 2025
@cdransf @castastrophe
fix(*): define missing custom properties from theme directory (#3517)
58cb9bf 
* fix(*): define missing custom properties from theme directory

* fix(*): restore missing mods and tokens

* fix(*): restore missing mod and update metadata

* fix(*): restore missing mods and update metadata

* fix(*): restore basebutton import

* chore(*): update metadata

This reverts commit 3d489fe.

* fix(*): restore actionbutton staticwhite background color

* chore(*): update metadata

* chore: resolve conflict

* fix(*): actionbutton emphasized + static conflict

* fix(*): actionbutton restore missing mods

* fix(*): actionbutton clean up mods; fix missing states

* fix(*): actionbutton restore focus indicator mods

* chore(*): remove unused theme files
castastrophe pushed a commit that referenced this pull request Feb 11, 2025
@cdransf @castastrophe
fix(actionbutton,avatar,button,dialog): define missing custom propert…
ea76c41 
…ies from theme directory (#3517)

* restore missing mods and tokens
* restore missing mod and update metadata
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
@cdransf @castastrophe
fix(actionbutton,avatar,button,dialog): define missing custom propert…
aa2ac87 
…ies from theme directory (#3517)

* restore missing mods and tokens
* restore missing mod and update metadata
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
@cdransf @castastrophe
fix(actionbutton,avatar,button,dialog): define missing custom propert…
d43d76d 
…ies from theme directory (#3517)

* restore missing mods and tokens
* restore missing mod and update metadata
castastrophe pushed a commit that referenced this pull request Feb 25, 2025
@cdransf @castastrophe
fix(actionbutton,avatar,button,dialog): define missing custom propert…
91d2cf4 
…ies from theme directory (#3517)

* restore missing mods and tokens
* restore missing mod and update metadata
@castastrophe castastrophe mentioned this pull request Apr 15, 2025
Merged
12 tasks
This was referenced May 16, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfulton pfulton pfulton approved these changes

@castastrophe castastrophe Awaiting requested review from castastrophe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdransf @pfulton