-
Notifications
You must be signed in to change notification settings - Fork 201
docs(avatar): update sizing documentation #3483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(avatar): update sizing documentation #3483
Conversation
|
🚀 Deployed on https://pr-3483--spectrum-css.netlify.app |
File metricsSummaryTotal size: 1.73 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
* Avatar is available in many sizes using the required `.spectrum-Avatar--size<number>` class. The available size classes are: | ||
|
||
- `spectrum-Avatar--size50` | ||
- `spectrum-Avatar--size75` | ||
- `spectrum-Avatar--size100` | ||
- `spectrum-Avatar--size200` | ||
- `spectrum-Avatar--size300` | ||
- `spectrum-Avatar--size400` | ||
- `spectrum-Avatar--size500` | ||
- `spectrum-Avatar--size600` | ||
- `spectrum-Avatar--size700` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I elected to remove this list. At first I was just going to add the new S2 sizes, but there's 8 additional sizes, that list got really long, and we're displaying all of the sizes in the canvas. So I worked the sentence here into the first paragraph and updated the range that's referenced instead.
Description
This PR updates the sizing documentation for avatar. There was an older table that listed the available sizes, but only for S1 avatars. The S2 avatar has more sizes available, so the Sizing story has now been updated to reflect that.
No changeset or VRTs needed since this was a documentation update only.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Sizing
documentation reflects the new S2 avatar sizes, with a range from 50 to 1500 (as opposed to the S1 50 to 700 range). The documentation should be free of grammar mistakes and be understandable/clear. The list of sizes has been removed. [@castastrophe]Regression testing
Validate:
Screenshots
To-do list