fix(icon): fix for icons not loading #3454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🚀 Deployed on https://pr-3454--spectrum-css.netlify.app |
Icons were not loading on the spectrum-two branch. The fetchIconSVG function is not working (this function no longer exists in main). This is a light touch update so icons appear, until spectrum-two is back up to date with main.
jawinn
force-pushed
the
jawinn/s2-icon-use-ref
branch
from
d371d1b to
35f9d74
Compare
File metricsSummaryTotal size: 2.74 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
cdransf
approved these changes
Dec 18, 2024
castastrophe
pushed a commit
that referenced
this pull request
Dec 27, 2024
Icons were not loading on the spectrum-two branch. The fetchIconSVG function is not working (this function no longer exists in main). This is a light touch update so icons appear, until spectrum-two is back up to date with main.
castastrophe
pushed a commit
that referenced
this pull request
Dec 29, 2024
Icons were not loading on the spectrum-two branch. The fetchIconSVG function is not working (this function no longer exists in main). This is a light touch update so icons appear, until spectrum-two is back up to date with main.
castastrophe
pushed a commit
that referenced
this pull request
Dec 29, 2024
Icons were not loading on the spectrum-two branch. The fetchIconSVG function is not working (this function no longer exists in main). This is a light touch update so icons appear, until spectrum-two is back up to date with main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Icons were not loading on the
spectrum-twobranch. Therequirestatements in thefetchIconSVGfunction are not working, but that function no longer exists inmain. This is a light touch update so icons appear for the current work, untilspectrum-twois back up to date with main.This updates the default
useRefto true in the Icon component, so icons use the spritesheet version.useRefis not set to anything other than the default in the repo.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
To-do list