-
Notifications
You must be signed in to change notification settings - Fork 201
chore(calendar,card,coachmark): remove MDX files #3443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
castastrophe
merged 10 commits into
s2-foundations-redux
from
marissahuysentruyt/css-1048-refactor-calendar-card-coachmark-mdx
Dec 19, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
869b4a7
chore(card): remove default args from test cases
marissahuysentruyt 96c3a4a
docs(card): remove MDX file
marissahuysentruyt 107f56f
docs(coachmark): remove MDX file
marissahuysentruyt 2050b36
chore(coachmark): adds extra chromatic coverage
marissahuysentruyt 8feb55a
docs(calendar): remove MDX file
marissahuysentruyt e5960d2
docs(calendar): clarifies days of the week control name
marissahuysentruyt 3547bf7
docs(card): clarify quiet control requirements
marissahuysentruyt eafa70e
chore(coachmark): remove html wrapper in favor of content array
marissahuysentruyt e2a3bb8
chore(card): fix isQuiet controls and usage in template
marissahuysentruyt 874f6cc
docs(asset,card): isCardAssetOverride renamed to isImageFill
marissahuysentruyt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could understand if we wanted to remove this for now. It definitely feels like we could get this to work in the template, but I didn't want to sink too much time dedicated to that, in this PR.