Skip to content

refactor(button): remove spectrum-ButtonWithFocusRing extend #2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2024
Merged

refactor(button): remove spectrum-ButtonWithFocusRing extend #2725

merged 1 commit into from
May 30, 2024

Conversation

jawinn
Copy link
Collaborator

@jawinn jawinn commented May 2, 2024 •
edited
Loading

Description

refactor: remove spectrum-ButtonWithFocusRing placeholder class extend from the button component

Removes the need for the extend from this placeholder class in the button component, as the styles it provides have diverged slightly from what is in button and it was causing some unnecessary CSS to override. This should not result in any changed visuals or behavior, as the same CSS has been integrated.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Button visuals are not affected. Focus indicator ring remains unchanged (test button sizes and wrapping button).

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 2, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 3f67a84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024 •
edited
Loading

File metrics

Summary

Total size: 4.24 MB*
Total change (Δ): ⬇ 2.19 KB (-0.05%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
button 29.47 KB ⬇ 0.73 KB

Details

button

File Head Base Δ
index-base.css 29.47 KB 30.18 KB ⬇ 0.73 KB (-2.37%)
index-vars.css 29.47 KB 30.18 KB ⬇ 0.73 KB (-2.37%)
index.css 29.47 KB 30.18 KB ⬇ 0.73 KB (-2.37%)
metadata.json 11.48 KB 11.52 KB ⬇ 0.04 KB (-0.34%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024 •
edited
Loading

🚀 Deployed on https://pr-2725--spectrum-css.netlify.app

@pfulton pfulton added S2 Spectrum 2 run_vrt For use on PRs looking to kick off VRT labels May 3, 2024
@jawinn
refactor(button): remove spectrum-ButtonWithFocusRing extend
3f67a84 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
@jawinn jawinn force-pushed the jawinn/refactor-button-remove-basebutton-focus branch from 388b57b to 3f67a84 Compare May 30, 2024 20:38
@pfulton pfulton merged commit 81edcde into spectrum-two May 30, 2024
13 checks passed
@pfulton pfulton deleted the jawinn/refactor-button-remove-basebutton-focus branch May 30, 2024 20:59
@github-actions github-actions bot mentioned this pull request May 30, 2024
Merged
castastrophe pushed a commit that referenced this pull request Dec 27, 2024
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
769343f 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Dec 29, 2024
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
ec7f9a2 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Dec 29, 2024
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
30706e7 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
aramos-adobe pushed a commit that referenced this pull request Jan 9, 2025
@jawinn @aramos-adobe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
584f0b3 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Jan 17, 2025
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
96cd0da 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Jan 17, 2025
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
316ea3b 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Jan 21, 2025
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
83a2f77 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Jan 22, 2025
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
2a26dd6 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Feb 5, 2025
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
7c6296e 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Feb 7, 2025
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
da4922f 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Feb 7, 2025
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
ca182b6 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Feb 7, 2025
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
8d6c00c 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Feb 11, 2025
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
8983275 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
11e672e 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Feb 24, 2025
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
b6cf87c 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
castastrophe pushed a commit that referenced this pull request Feb 25, 2025
@jawinn @castastrophe
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
f90cc36 
The styles had previously diverged from what this placeholder class was
providing, which was causing an issue with needing to override styles
with unnecessary CSS. This cleans that up by integrating the small
number of styles from spectrum-ButtonWithFocusRing that were not already
present, and removing that "extend".
@castastrophe castastrophe mentioned this pull request Apr 15, 2025
Merged
12 tasks
This was referenced May 16, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfulton pfulton pfulton approved these changes

Assignees
No one assigned
Labels
ready-for-review run_vrt For use on PRs looking to kick off VRT S2 Spectrum 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawinn @pfulton