ci: ensure the shas used by compare match the current PR #2629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2629--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.51 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
castastrophe
force-pushed
the
ci-fix-compare-shas
branch
from
33f8514 to
2e8fd91
Compare
castastrophe
added
skip_vrt
mdt2
approved these changes
Apr 1, 2024
castastrophe
force-pushed
the
ci-fix-compare-shas
branch
from
2e8fd91 to
56be422
Compare
castastrophe
force-pushed
the
ci-fix-compare-shas
branch
from
56be422 to
2a49eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I noticed that the base branch being used by the compare tool was main and not spectrum-two as expected. When I investigated further, I found in the logs that it was using the default base branch rather than the base branch for the PR. To fix this, I've added a get-SHAs workflow that will fetch and pass the appropriate SHA values to the compare script.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
To-do list