-
Notifications
You must be signed in to change notification settings - Fork 201
fix(stepper): no longer touches InfieldButton classes #2300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
File metricsSummaryTotal size: 4.06 MB*
Detailsinfieldbutton
stepper
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
🚀 Deployed on https://pr-2300--spectrum-css.netlify.app |
95d2f20
to
3596b3c
Compare
c8dfb99
to
b297a7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I just have one question about two of the newly defined custom properties on .spectrum-InfieldButton
that may not be needed.
b297a7a
to
4dc140f
Compare
4b204bf
to
4f76b8b
Compare
4f76b8b
to
dbc7e3d
Compare
* fix(stepper): no longer touches InfieldButton classes * fix(stepper): button size + space match infieldbutton spec
Description
Per issue #2234, Stepper shouldn't be using classes that it doesn't own. This PR adds some properties to InfieldButton and uses their mods to modify them for Stepper so that we no longer touch InfieldButton classes inside our Stepper component. There should be no visual differences to the components.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Note: When reviewing the code, filter commits so that you aren't reviewing separate changes made in PR #2234.
Tested by @jawinn
Regression testing
Validate:
To-do list