Skip to content

chore: update javascript for site to account for removal of focus-ring #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

mlogsdon18
Copy link
Contributor

@mlogsdon18 mlogsdon18 commented Aug 18, 2023

Description

Removing the focus-ring polyfill affect some custom JavaScript that we had running on the docs site to add/remove the .is-focused and .is-keyboardFocused classes for certain components. This PR updates that JavaScript to run without the need for the focus-ring class.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Regression testing

Validate:

  1. A legacy documentation page (such as accordion), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive
  1. A migrated documentation page (such as action group), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@mlogsdon18 mlogsdon18 force-pushed the fix--docs-focus-javascript branch from f2ebf84 to a82fa82 Compare August 18, 2023 17:34
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

🚀 Deployed on https://pr-2102--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 18, 2023 17:41 Inactive
@castastrophe castastrophe force-pushed the fix--docs-focus-javascript branch from a82fa82 to cd716ed Compare August 21, 2023 13:28
@castastrophe castastrophe added the run_vrt For use on PRs looking to kick off VRT label Aug 21, 2023
@castastrophe castastrophe changed the title fix: update javascript for site to account for removal of focus-ring chore: update javascript for site to account for removal of focus-ring Aug 21, 2023
@github-actions github-actions bot temporarily deployed to pull request August 21, 2023 13:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 21, 2023 14:52 Inactive
@mlogsdon18 mlogsdon18 force-pushed the fix--docs-focus-javascript branch from dabc564 to 30a5dc3 Compare August 21, 2023 14:58
@castastrophe
Copy link
Collaborator

Looks great!

@castastrophe castastrophe force-pushed the fix--docs-focus-javascript branch from 30a5dc3 to cc06560 Compare August 21, 2023 15:03
@github-actions github-actions bot temporarily deployed to pull request August 21, 2023 15:09 Inactive
@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT skip_vrt Add to a PR to skip running VRT (but still pass the action) and removed run_vrt For use on PRs looking to kick off VRT labels Aug 21, 2023
@castastrophe castastrophe merged commit 8c276f8 into main Aug 21, 2023
@castastrophe castastrophe deleted the fix--docs-focus-javascript branch August 21, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants