-
Notifications
You must be signed in to change notification settings - Fork 201
chore: update javascript for site to account for removal of focus-ring #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2ebf84
to
a82fa82
Compare
🚀 Deployed on https://pr-2102--spectrum-css.netlify.app |
castastrophe
approved these changes
Aug 21, 2023
a82fa82
to
cd716ed
Compare
castastrophe
requested changes
Aug 21, 2023
dabc564
to
30a5dc3
Compare
castastrophe
approved these changes
Aug 21, 2023
Looks great! |
30a5dc3
to
cc06560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the focus-ring polyfill affect some custom JavaScript that we had running on the docs site to add/remove the
.is-focused
and.is-keyboardFocused
classes for certain components. This PR updates that JavaScript to run without the need for the focus-ring class.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Regression testing
Validate:
To-do list