Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: adobe/spectrum-css
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @spectrum-css/preview@8.0.1
Choose a base ref
...
head repository: adobe/spectrum-css
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @spectrum-css/preview@8.0.2
Choose a head ref
  • 12 commits
  • 61 files changed
  • 6 contributors

Commits on Feb 16, 2024

  1. Configuration menu
    Copy the full SHA
    e3eda5d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    468b426 View commit details
    Browse the repository at this point in the history
  3. refactor(cyclebutton): deprecate component (#2538)

    Melissa Thompson authored Feb 16, 2024
    Configuration menu
    Copy the full SHA
    8e2010c View commit details
    Browse the repository at this point in the history
  4. fix(textfield): remove extra padding on nested label and help (#2519)

    * fix(textfield): nested label extra inline start padding
    
    There were styles that were adding extra inline start padding to the
    label and help text, when they are nested within Textfield (as shown on
    the docs page for Textfield). This was particularly noticeable on the
    quiet variation.
    
    It looks like this previously was adding padding that matched the amount
    of corner rounding, so text would start where the corner started its
    curve.
    
    On the design, there is no additional left padding. This update removes
    that padding to adhere to the design.
    
    * docs(textfield): use correct icon set for valid icon in storybook
    
    Define the icon set used for the valid and invalid icons in Textfield.
    
    This necessary story update was related to recent fixes to icon that
    addressed the fact that icons with the same name exist in both
    icon sets. This one wasn't caught in VRTs because Textfield does not
    have a kitchen sink style story yet to represent all of its states.
    jawinn authored Feb 16, 2024
    Configuration menu
    Copy the full SHA
    0250d0e View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Configuration menu
    Copy the full SHA
    a7e09d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    790549f View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. chore(deps-dev): bump the storybook-ecosystem group with 14 updates (#…

    …2541)
    
    Bumps the storybook-ecosystem group with 14 updates:
    
    | Package | From | To |
    | --- | --- | --- |
    | [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y) | `7.6.14` | `7.6.16` |
    | [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/actions) | `7.6.14` | `7.6.16` |
    | [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/docs) | `7.6.14` | `7.6.16` |
    | [@storybook/addon-interactions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions) | `7.6.14` | `7.6.16` |
    | [@storybook/api](https://github.com/storybookjs/storybook/tree/HEAD/code/deprecated/manager-api-shim) | `7.6.14` | `7.6.16` |
    | [@storybook/blocks](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/blocks) | `7.6.14` | `7.6.16` |
    | [@storybook/client-api](https://github.com/storybookjs/storybook/tree/HEAD/code/deprecated/client-api) | `7.6.14` | `7.6.16` |
    | [@storybook/components](https://github.com/storybookjs/storybook/tree/HEAD/code/ui/components) | `7.6.14` | `7.6.16` |
    | [@storybook/core-events](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/core-events) | `7.6.14` | `7.6.16` |
    | [@storybook/manager-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/manager-api) | `7.6.14` | `7.6.16` |
    | [@storybook/preview-api](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/preview-api) | `7.6.14` | `7.6.16` |
    | [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming) | `7.6.14` | `7.6.16` |
    | [@storybook/web-components-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/web-components-webpack5) | `7.6.14` | `7.6.16` |
    | [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli) | `7.6.14` | `7.6.16` |
    
    
    Updates `@storybook/addon-a11y` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/addons/a11y)
    
    Updates `@storybook/addon-actions` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/addons/actions)
    
    Updates `@storybook/addon-docs` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/addons/docs)
    
    Updates `@storybook/addon-interactions` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/addons/interactions)
    
    Updates `@storybook/api` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/v7.6.16/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/deprecated/manager-api-shim)
    
    Updates `@storybook/blocks` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/ui/blocks)
    
    Updates `@storybook/client-api` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/v7.6.16/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/deprecated/client-api)
    
    Updates `@storybook/components` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/ui/components)
    
    Updates `@storybook/core-events` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/lib/core-events)
    
    Updates `@storybook/manager-api` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/lib/manager-api)
    
    Updates `@storybook/preview-api` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/lib/preview-api)
    
    Updates `@storybook/theming` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/lib/theming)
    
    Updates `@storybook/web-components-webpack5` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/frameworks/web-components-webpack5)
    
    Updates `storybook` from 7.6.14 to 7.6.16
    - [Release notes](https://github.com/storybookjs/storybook/releases)
    - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
    - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.16/code/lib/cli)
    
    ---
    updated-dependencies:
    - dependency-name: "@storybook/addon-a11y"
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/addon-actions"
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/addon-docs"
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/addon-interactions"
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/api"
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/blocks"
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/client-api"
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/components"
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/core-events"
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/manager-api"
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/preview-api"
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/theming"
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    - dependency-name: "@storybook/web-components-webpack5"
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    - dependency-name: storybook
      dependency-type: direct:development
      update-type: version-update:semver-patch
      dependency-group: storybook-ecosystem
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    8470909 View commit details
    Browse the repository at this point in the history
  2. chore(deps): bump postcss from 8.4.34 to 8.4.35 (#2545) (#2534)

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    castastrophe and dependabot[bot] authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5524456 View commit details
    Browse the repository at this point in the history
  3. fix(button): support for wrapping text (#2248)

    * fix(button): restore ability for button text to wrap
    
    Remove the CSS that prevents the text in the button from wrapping.
    
    The guidelines for the component say "When the button text is too long
    for the horizontal space available, it wraps to form another line."
    
    * docs(button): add wrapping text story
    
    Add "Wrapping" story that demonstrates a button with long text that
    wraps to the next line. Some template adjustments and additional args
    added to allow for this.
    
    * fix(button)!: icon alignment when text is wrapping
    
    BREAKING CHANGE: changes vertical flex alignment to start.
    
    Previously when the button had an icon and the text was wrapping, the
    icon was vertically aligned center and the text was aligned center.
    
    This fixes this to match with the design spec: for the version of the
    button that uses a workflow icon, the icon should stay aligned to the
    top, and the text should be aligned left (start). This uses the defined
    token for the space between the top of the component and the workflow
    icon (--spectrum-component-top-to-workflow-icon-*).
    
    * docs(button): rename storybook control to layout
    
    Rename Storybook control for stacking buttons to "layout" with specified
    options, which is a more appropriate name. The control has also been
    made visible.
    
    * fix(button): support any existing use of ui icons
    
    Support any existing use of ui icons with the updated wrapping behavior.
    And add Chromatic only testing of them to the Wrapping story.
    
    Workflow icons are intended, with the use of the
    spectrum-component-top-to-workflow-icon tokens, but UI icons have not
    yet been specifically excluded in guidelines and are currently in use
    within SplitButton in this library. This keeps UI icons that are
    smaller than the intended workflow icon, better vertically centered
    with the text within the button.
    
    * feat(button): mod property for icon margin top
    
    Add a mod property to make it easy to modify the margin-block-start of
    the icon, in case of alignment issues with icons that are not the
    intended workflow sizes.
    jawinn authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    3f14a86 View commit details
    Browse the repository at this point in the history
  4. fix(tray): full width at portrait orientation (#2547)

    * docs(tray): docs update and fix guidelines link
    
    Fix incorrect Tray guidelines link that was 404 not found.
    Update descriptions in docs to clarify viewport orientation differences.
    
    * fix(tray): full width at portrait
    
    The Tray was not appearing as 100% width in portrait orientation because
    of a max-inline-size declaration coming from the .spectrum-Modal class
    used with .spectrum-Tray
    
    * fix(tray): whcm use border on correct element to show rounding
    
    Rounded corners were not showing in forced-colors mode, because the
    border that was appearing on the nested Dialog element, which has
    padding. Moves the high contrast border from that element to the root
    Tray element.
    
    * fix(tray): storybook heading text control and unused import
    
    The Storybook "heading" control was previously not usable, due to how
    the arg was being passed through to the Dialog. This text string control
    will now change the heading.
    
    Replaces an "unused" import for Modal whose CSS is still necessary for
    the Tray to render correctly. The unused import would be deleted on
    save/fix, resulting in the wrong styles. Replaced the template import
    with an import of just the CSS for Modal.
    jawinn authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c9a79f2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b20ebb6 View commit details
    Browse the repository at this point in the history
  6. chore(release): release

     - @spectrum-css/preview@8.0.2
     - @spectrum-css/button@12.0.0
     - @spectrum-css/textfield@6.1.4
     - @spectrum-css/tray@2.2.5
     - @spectrum-tools/stylelint-no-unknown-custom-properties@1.3.2
     - @spectrum-css/tokens@13.2.0
     - @spectrum-css/bundle-builder@7.0.1
     - @spectrum-css/component-builder-simple@5.0.3
     - @spectrum-css/component-builder@7.0.1
    pfulton committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    565294a View commit details
    Browse the repository at this point in the history
Loading