Skip to content

Commit f90cc36

Browse files
jawinncastastrophe
authored andcommitted
refactor(button): remove spectrum-ButtonWithFocusRing extend (#2725)
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
1 parent d125b43 commit f90cc36

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

.changeset/fresh-seahorses-join.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
"@spectrum-css/button": patch
3+
---
4+
5+
#### refactor: remove spectrum-ButtonWithFocusRing placeholder class extend
6+
7+
Removes the need for the extend from this placeholder class, as the styles it provides have diverged slightly from what is in button and it was causing some unnecessary CSS to override.
8+
This should not result in any changed visuals or behavior, as the same CSS has been integrated.

components/button/index.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@
125125

126126
/* ---- Accent ---- */
127127
/* Also shows as the default when a variant class is not used. */
128-
&,
128+
&,
129129
&.spectrum-Button--accent {
130130
--spectrum-button-background-color-default: var(--spectrum-accent-background-color-default);
131131
--spectrum-button-background-color-hover: var(--spectrum-accent-background-color-hover);

0 commit comments

Comments
 (0)