Skip to content

Commit f3b1c35

Browse files
fix: prevent hover from overriding active styles
Accordion item's background color should change on active, but it wasn't visible when it was active and hovered. Active styles should take precedence over hover styles but the @hover media query prevents this. To fix this, the specificity of the active styles was increased, similar to #3767.
1 parent b776bbf commit f3b1c35

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

components/accordion/dist/metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
".spectrum-Accordion-item:first-child",
2424
".spectrum-Accordion-itemContent",
2525
".spectrum-Accordion-itemHeader",
26-
".spectrum-Accordion-itemHeader:active",
26+
".spectrum-Accordion-itemHeader.spectrum-Accordion-itemHeader:active",
2727
".spectrum-Accordion-itemHeader:focus-visible",
2828
".spectrum-Accordion-itemHeader:hover",
2929
".spectrum-Accordion-itemHeading",

components/accordion/index.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,8 @@
308308
outline-offset: var(--mod-accordion-item-focus-indicator-gap, var(--spectrum-accordion-item-focus-indicator-gap), 0);
309309
}
310310

311-
&:active {
311+
/* higher specificity to maintain active styles over @media hover styles */
312+
&.spectrum-Accordion-itemHeader:active {
312313
background-color: var(--spectrum-accordion-background-color-down);
313314
color: var(--spectrum-accordion-item-header-color-down);
314315
}

0 commit comments

Comments
 (0)