Skip to content

Commit db7b8b2

Browse files
jianliaoJian Liao
andauthored
fix: change workflow icon size to medium for most of the examples (#962)
Co-authored-by: Jian Liao <jianliao@adobe.com>
1 parent c539411 commit db7b8b2

File tree

5 files changed

+66
-43
lines changed

5 files changed

+66
-43
lines changed

components/divider/metadata/divider.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@ SpectrumSiteSlug: https://spectrum.adobe.com/page/divider/
44
sections:
55
- name: Migrating from Rule
66
description: |
7+
### Component rename
78
Rule is now named Divider. All instances of `.spectrum-Rule` in your code should be replaced with `.spectrum-Divider`, and the `@spectrum-css/divider` package should be used instead of `@spectrum-css/rule`.
9+
10+
### Change workflow icon size to medium
11+
Please replace `.spectrum-Icon--sizeS` with `.spectrum-Icon--sizeM`.
812
examples:
913
- id: divider-large
1014
name: 'Large'
@@ -32,13 +36,13 @@ examples:
3236
markup: |
3337
<div class="spectrum-ButtonGroup">
3438
<button class="spectrum-ActionButton spectrum-ActionButton--quiet">
35-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Properties">
39+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Properties">
3640
<use xlink:href="#spectrum-icon-18-Properties" />
3741
</svg>
3842
</button>
3943
<div class="spectrum-Divider spectrum-Divider--small spectrum-Divider--vertical" style="height: auto; align-self: stretch;"></div>
4044
<button class="spectrum-ActionButton spectrum-ActionButton--quiet">
41-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Select">
45+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Select">
4246
<use xlink:href="#spectrum-icon-18-Select" />
4347
</svg>
4448
</button>
@@ -48,13 +52,13 @@ examples:
4852
markup: |
4953
<div class="spectrum-ButtonGroup">
5054
<button class="spectrum-ActionButton spectrum-ActionButton--quiet">
51-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Properties">
55+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Properties">
5256
<use xlink:href="#spectrum-icon-18-Properties" />
5357
</svg>
5458
</button>
5559
<div class="spectrum-Divider spectrum-Divider--medium spectrum-Divider--vertical" style="height: auto; align-self: stretch;"></div>
5660
<button class="spectrum-ActionButton spectrum-ActionButton--quiet">
57-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Select">
61+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Select">
5862
<use xlink:href="#spectrum-icon-18-Select" />
5963
</svg>
6064
</button>

components/inputgroup/metadata/datepicker.yml

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@ description: A date picker uses the input group component to display a field wit
33
sections:
44
- name: Migration Guide
55
description: |
6-
See the [Combobox migration guide](combobox.html#migrationguide) for migration information.
6+
### Textfiled markup change
7+
See the [Combobox migration guide](combobox.html#migrationguide) for migration information.
8+
9+
### Change workflow icon size to medium
10+
Please replace `.spectrum-Icon--sizeS` with `.spectrum-Icon--sizeM`.
11+
712
813
examples:
914
- id: datepicker
@@ -14,7 +19,7 @@ examples:
1419
<input type="text" class="spectrum-Textfield-input spectrum-InputGroup-input" aria-invalid="false" placeholder="Choose a date" value="">
1520
</div>
1621
<button type="button" class="spectrum-FieldButton spectrum-InputGroup-button" tabindex="-1">
17-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Calendar">
22+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Calendar">
1823
<use xlink:href="#spectrum-icon-18-Calendar" />
1924
</svg>
2025
</button>
@@ -27,7 +32,7 @@ examples:
2732
<input type="text" class="spectrum-Textfield-input spectrum-InputGroup-input" aria-invalid="false" placeholder="Choose a date" value="">
2833
</div>
2934
<button type="button" class="spectrum-FieldButton spectrum-FieldButton--quiet spectrum-InputGroup-button" tabindex="-1">
30-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Calendar">
35+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Calendar">
3136
<use xlink:href="#spectrum-icon-18-Calendar" />
3237
</svg>
3338
</button>
@@ -44,7 +49,7 @@ examples:
4449
<input type="text" class="spectrum-Textfield-input spectrum-InputGroup-input spectrum-Datepicker-endField" placeholder="mm/dd/yyyy" name="end" value="">
4550
</div>
4651
<button type="button" class="spectrum-FieldButton spectrum-InputGroup-button" tabindex="-1" aria-expanded="false" aria-haspopup="dialog" aria-label="Calendar">
47-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Calendar">
52+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Calendar">
4853
<use xlink:href="#spectrum-icon-18-Calendar" />
4954
</svg>
5055
</button>
@@ -64,7 +69,7 @@ examples:
6469
<input type="text" class="spectrum-Textfield-input spectrum-InputGroup-input spectrum-Datepicker-endField" aria-invalid="true" placeholder="mm/dd/yyyy" name="end" value="">
6570
</div>
6671
<button type="button" class="spectrum-FieldButton is-invalid spectrum-InputGroup-button" tabindex="-1" aria-expanded="false" aria-haspopup="dialog" aria-label="Calendar">
67-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Calendar">
72+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Calendar">
6873
<use xlink:href="#spectrum-icon-18-Calendar" />
6974
</svg>
7075
</button>
@@ -81,7 +86,7 @@ examples:
8186
<input type="text" class="spectrum-Textfield-input spectrum-InputGroup-input spectrum-Datepicker-endField" placeholder="mm/dd/yyyy" name="end" value="" disabled>
8287
</div>
8388
<button type="button" class="spectrum-FieldButton spectrum-InputGroup-button" disabled tabindex="-1" aria-label="Calendar">
84-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Calendar">
89+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Calendar">
8590
<use xlink:href="#spectrum-icon-18-Calendar" />
8691
</svg>
8792
</button>
@@ -98,7 +103,7 @@ examples:
98103
<input type="text" class="spectrum-Textfield-input spectrum-InputGroup-input spectrum-Datepicker-endField" placeholder="mm/dd/yyyy hh:mm a" name="end" value="">
99104
</div>
100105
<button type="button" class="spectrum-FieldButton spectrum-InputGroup-button" tabindex="-1" aria-expanded="false" aria-haspopup="dialog" aria-label="Calendar">
101-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Calendar">
106+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Calendar">
102107
<use xlink:href="#spectrum-icon-18-Calendar" />
103108
</svg>
104109
</button>
@@ -117,7 +122,7 @@ examples:
117122
<input type="text" class="spectrum-Textfield-input spectrum-InputGroup-input spectrum-Datepicker-endField" placeholder="mm/dd/yyyy hh:mm a" name="end" value="">
118123
</div>
119124
<button type="button" class="spectrum-FieldButton spectrum-InputGroup-button is-invalid" tabindex="-1" aria-expanded="false" aria-haspopup="dialog" aria-label="Calendar">
120-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Calendar">
125+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Calendar">
121126
<use xlink:href="#spectrum-icon-18-Calendar" />
122127
</svg>
123128
</button>
@@ -134,7 +139,7 @@ examples:
134139
<input type="text" class="spectrum-Textfield-input spectrum-InputGroup-input spectrum-Datepicker-endField" placeholder="mm/dd/yyyy" name="end" value="2018-10-30">
135140
</div>
136141
<button type="button" class="spectrum-FieldButton spectrum-FieldButton--quiet spectrum-InputGroup-button" tabindex="-1" aria-label="Calendar">
137-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Calendar">
142+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Calendar">
138143
<use xlink:href="#spectrum-icon-18-Calendar" />
139144
</svg>
140145
</button>
@@ -154,7 +159,7 @@ examples:
154159
<input type="text" class="spectrum-Textfield-input spectrum-InputGroup-input spectrum-Datepicker-endField" aria-invalid="true" placeholder="mm/dd/yyyy" name="end" value="2018-10-30">
155160
</div>
156161
<button type="button" class="spectrum-FieldButton spectrum-FieldButton--quiet is-invalid spectrum-InputGroup-button" tabindex="-1" aria-expanded="false" aria-haspopup="dialog" aria-label="Calendar">
157-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Calendar">
162+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Calendar">
158163
<use xlink:href="#spectrum-icon-18-Calendar" />
159164
</svg>
160165
</button>
@@ -171,7 +176,7 @@ examples:
171176
<input type="text" class="spectrum-Textfield-input spectrum-InputGroup-input spectrum-Datepicker-endField" placeholder="mm/dd/yyyy" name="end" value="2018-10-30" disabled>
172177
</div>
173178
<button type="button" class="spectrum-FieldButton spectrum-FieldButton--quiet spectrum-InputGroup-button" tabindex="-1" disabled aria-expanded="false" aria-haspopup="dialog" aria-label="Calendar">
174-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Calendar">
179+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Calendar">
175180
<use xlink:href="#spectrum-icon-18-Calendar" />
176181
</svg>
177182
</button>
@@ -187,7 +192,7 @@ examples:
187192
<input type="text" class="spectrum-Textfield-input spectrum-InputGroup-input spectrum-Datepicker-endField" aria-invalid="false" placeholder="mm/dd/yyyy hh:mm a" name="end" value="">
188193
</div>
189194
<button type="button" class="spectrum-FieldButton spectrum-FieldButton--quiet spectrum-InputGroup-button" tabindex="-1" aria-expanded="false" aria-haspopup="dialog" aria-label="Calendar">
190-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Calendar">
195+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Calendar">
191196
<use xlink:href="#spectrum-icon-18-Calendar" />
192197
</svg>
193198
</button>
@@ -206,7 +211,7 @@ examples:
206211
<input type="text" class="spectrum-Textfield-input spectrum-InputGroup-input spectrum-Datepicker-endField" aria-invalid="false" placeholder="mm/dd/yyyy hh:mm a" name="end" value="">
207212
</div>
208213
<button type="button" class="spectrum-FieldButton spectrum-FieldButton--quiet spectrum-InputGroup-button is-invalid" tabindex="-1" aria-expanded="false" aria-haspopup="dialog" aria-label="Calendar">
209-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Calendar">
214+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Calendar">
210215
<use xlink:href="#spectrum-icon-18-Calendar" />
211216
</svg>
212217
</button>

components/menu/metadata/menu.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
name: Menu
22
SpectrumSiteSlug: https://spectrum.adobe.com/page/side-navigation/
3+
section:
4+
- name: Migration Guide
5+
description: |
6+
### Change workflow icon size to medium
7+
Please replace `.spectrum-Icon--sizeS` with `.spectrum-Icon--sizeM`.
38
examples:
49
- id: selectlist
510
name: Standard
@@ -48,13 +53,13 @@ examples:
4853
<span class="spectrum-Menu-sectionHeading" id="menu-heading-category-2" aria-hidden="true">Section Heading</span>
4954
<ul class="spectrum-Menu" role="group" aria-labelledby="menu-heading-category-1" aria-disabled="true">
5055
<li class="spectrum-Menu-item" role="menuitem" tabindex="0">
51-
<svg class="spectrum-Icon spectrum-Icon--sizeS spectrum-Menu-itemIcon" focusable="false" aria-hidden="true" aria-label="SaveFloppy">
56+
<svg class="spectrum-Icon spectrum-Icon--sizeM spectrum-Menu-itemIcon" focusable="false" aria-hidden="true" aria-label="SaveFloppy">
5257
<use xlink:href="#spectrum-icon-18-SaveFloppy"></use>
5358
</svg>
5459
<span class="spectrum-Menu-itemLabel">Save</span>
5560
</li>
5661
<li class="spectrum-Menu-item is-disabled" role="menuitem" aria-disabled="true">
57-
<svg class="spectrum-Icon spectrum-Icon--sizeS spectrum-Menu-itemIcon" focusable="false" aria-hidden="true" aria-label="DataDownload">
62+
<svg class="spectrum-Icon spectrum-Icon--sizeM spectrum-Menu-itemIcon" focusable="false" aria-hidden="true" aria-label="DataDownload">
5863
<use xlink:href="#spectrum-icon-18-DataDownload"></use>
5964
</svg>
6065
<span class="spectrum-Menu-itemLabel">Download</span>

components/quickaction/metadata/quickaction.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ name: Quick Actions
33
status: Verified
44
description: 'Note that the `.spectrum-QuickActions-overlay` class should be placed on the container where the Quick Actions are displayed, and the `.spectrum-QuickActions--textOnly` class should be applied when the buttons have text only.'
55
SpectrumSiteSlug: https://spectrum.adobe.com/page/quick-actions/
6+
section:
7+
- name: Migration Guide
8+
description: |
9+
### Change workflow icon size to medium
10+
Please replace `.spectrum-Icon--sizeS` with `.spectrum-Icon--sizeM`.
611
examples:
712
- id: quickactions
813
name: Standard
@@ -11,17 +16,17 @@ examples:
1116
1217
<div class="spectrum-QuickActions is-open">
1318
<button class="spectrum-ActionButton spectrum-ActionButton--quiet">
14-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Edit">
19+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Edit">
1520
<use xlink:href="#spectrum-icon-18-Edit" />
1621
</svg>
1722
</button>
1823
<button class="spectrum-ActionButton spectrum-ActionButton--quiet">
19-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Copy">
24+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Copy">
2025
<use xlink:href="#spectrum-icon-18-Copy" />
2126
</svg>
2227
</button>
2328
<button class="spectrum-ActionButton spectrum-ActionButton--quiet">
24-
<svg class="spectrum-Icon spectrum-Icon--sizeS" focusable="false" aria-hidden="true" aria-label="Delete">
29+
<svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Delete">
2530
<use xlink:href="#spectrum-icon-18-Delete" />
2631
</svg>
2732
</button>

0 commit comments

Comments
 (0)