Skip to content

Commit c21cbfd

Browse files
committed
fix(pagination): deprecate legacy features to align with foundations
1 parent 142757e commit c21cbfd

File tree

5 files changed

+25
-43
lines changed

5 files changed

+25
-43
lines changed

.storybook/modes/index.js

Lines changed: 13 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -12,31 +12,22 @@
1212
*/
1313

1414
const modes = {
15-
"Light | LTR": {
16-
color: "light",
17-
textDirection: "ltr",
18-
},
19-
"Dark | RTL": {
20-
color: "dark",
21-
textDirection: "rtl",
22-
},
23-
"S1 | Light | LTR": {
24-
context: "legacy",
25-
color: "light",
26-
textDirection: "ltr",
27-
},
28-
"Express | Light | LTR": {
29-
context: "express",
30-
color: "light",
31-
textDirection: "ltr",
32-
},
15+
Light: {
16+
color: "light",
17+
},
18+
Dark: {
19+
color: "dark",
20+
},
21+
RTL: {
22+
textDirection: "rtl",
23+
},
3324
};
3425

3526
export default modes;
3627

3728
export const disableDefaultModes = {
38-
...Object.keys(modes).reduce((acc, key) => {
39-
acc[key] = { disable: true };
40-
return acc;
41-
}, {}),
29+
...Object.keys(modes).reduce((acc, key) => {
30+
acc[key] = { disable: true };
31+
return acc;
32+
}, {}),
4233
};

.storybook/preview.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ export const parameters = {
9090
// Set an empty object to avoid the "undefined" value in the ComponentDetails doc block
9191
packageJson: {},
9292
// A list of published npm tags that should not appear in the ComponentDetails doc block
93-
ignoredTags: ["beta", "next"],
93+
ignoredTags: ["beta"],
9494
};
9595

9696
export default {

components/card/index.css

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030

3131
--spectrum-card-border-width: var(--mod-card-border-width, var(--spectrum-border-width-100));
3232
--spectrum-card-corner-radius: var(--mod-card-corner-radius, var(--spectrum-corner-radius-100));
33+
--spectrum-card-border-color-selected: var(--mod-card-border-color-selected, var(--spectrum-blue-700));
3334

3435
/* Typography */
3536
--spectrum-card-title-font-family: var(--mod-card-title-font-family, var(--spectrum-sans-font-family-stack));
@@ -81,13 +82,6 @@
8182
--spectrum-card-content-margin-top: var(--spectrum-spacing-100);
8283
}
8384

84-
&.is-selected,
85-
&.is-drop-target {
86-
--spectrum-card-border-color: var(--mod-card-border-color-selected, var(--spectrum-blue-700));
87-
}
88-
}
89-
90-
.spectrum-Card {
9185
position: relative;
9286
display: inline-flex;
9387
flex-direction: column;

components/pagination/CHANGELOG.md

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,11 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
172172

173173
🗓 2024-04-18 • 📝 [Commits](https://github.com/adobe/spectrum-css/compare/@spectrum-css/pagination@7.1.6...@spectrum-css/pagination@8.0.0)
174174

175-
\*feat!: postcss config build and script; remove gulp (#2466)([b0f337b](https://github.com/adobe/spectrum-css/commit/b0f337b)), closes[#2466](https://github.com/adobe/spectrum-css/issues/2466)
175+
- feat!: postcss config build and script; remove gulp (#2466)([b0f337b](https://github.com/adobe/spectrum-css/commit/b0f337b)), closes[#2466](https://github.com/adobe/spectrum-css/issues/2466)
176176

177177
### 🛑 BREAKING CHANGES
178-
- Removes component-builder & component-builder-simple for script leveraging postcss
179178

179+
- Removes component-builder & component-builder-simple for script leveraging postcss
180180
- Imports added to index.css and themes/express.css
181181

182182
<a name="7.1.6"></a>
@@ -227,7 +227,7 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
227227

228228
### 🐛 Bug fixes
229229

230-
\*deprecate logical transform plugin ([#2437](https://github.com/adobe/spectrum-css/issues/2437))([ff5dda6](https://github.com/adobe/spectrum-css/commit/ff5dda6))
230+
- deprecate logical transform plugin ([#2437](https://github.com/adobe/spectrum-css/issues/2437))([ff5dda6](https://github.com/adobe/spectrum-css/commit/ff5dda6))
231231

232232
<a name="7.1.0"></a>
233233

@@ -237,7 +237,7 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
237237

238238
### ✨ Features
239239

240-
\*remove theme files without content([1eadd4f](https://github.com/adobe/spectrum-css/commit/1eadd4f))
240+
- remove theme files without content([1eadd4f](https://github.com/adobe/spectrum-css/commit/1eadd4f))
241241

242242
<a name="7.0.5"></a>
243243

@@ -255,7 +255,7 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
255255

256256
**Note:** Version bump only for package @spectrum-css/pagination
257257

258-
<a name="7.0.3"></a>
258+
<a name="7.0.3"></a>'
259259

260260
## 7.0.3
261261

@@ -285,12 +285,11 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
285285

286286
🗓 2023-10-13 • 📝 [Commits](https://github.com/adobe/spectrum-css/compare/@spectrum-css/pagination@6.0.50...@spectrum-css/pagination@7.0.0)
287287

288-
\*feat(pagination)!: migrate to spectrum tokens package([f29a74d](https://github.com/adobe/spectrum-css/commit/f29a74d))
288+
- feat(pagination)!: migrate to spectrum tokens package([f29a74d](https://github.com/adobe/spectrum-css/commit/f29a74d))
289289

290290
### 🛑 BREAKING CHANGES
291291

292-
*
293-
Replaces DNA tokens with Spectrum tokens.
292+
- Replaces DNA tokens with Spectrum tokens.
294293

295294
Update build to use Spectrum tokens.
296295
Remove skin.css and incorporate its CSS into index.css.
@@ -405,7 +404,7 @@ Add the "Button style" version of Pagination from the docs to Storybook.
405404

406405
### 🔙 Reverts
407406

408-
\*gulp and build updates ([#2121](https://github.com/adobe/spectrum-css/issues/2121))([03a37f5](https://github.com/adobe/spectrum-css/commit/03a37f5)), closes[#2099](https://github.com/adobe/spectrum-css/issues/2099)
407+
- gulp and build updates ([#2121](https://github.com/adobe/spectrum-css/issues/2121))([03a37f5](https://github.com/adobe/spectrum-css/commit/03a37f5)), closes[#2099](https://github.com/adobe/spectrum-css/issues/2099)
409408

410409
<a name="6.0.40"></a>
411410

@@ -471,7 +470,7 @@ Add the "Button style" version of Pagination from the docs to Storybook.
471470

472471
### 🐛 Bug fixes
473472

474-
\*icon sizing in Storybook story templates ([#2037](https://github.com/adobe/spectrum-css/issues/2037))([c90c8a3](https://github.com/adobe/spectrum-css/commit/c90c8a3))
473+
- icon sizing in Storybook story templates ([#2037](https://github.com/adobe/spectrum-css/issues/2037))([c90c8a3](https://github.com/adobe/spectrum-css/commit/c90c8a3))
475474

476475
<a name="6.0.32"></a>
477476

@@ -529,7 +528,7 @@ Add the "Button style" version of Pagination from the docs to Storybook.
529528

530529
### 🐛 Bug fixes
531530

532-
\*restore files to pre-formatted state([491dbcb](https://github.com/adobe/spectrum-css/commit/491dbcb))
531+
- restore files to pre-formatted state([491dbcb](https://github.com/adobe/spectrum-css/commit/491dbcb))
533532

534533
<a name="6.0.25"></a>
535534

tools/generator/templates/index.css.hbs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
// color: var(--highcontrast-{{ folderName }}-content-color-default, var(--mod-{{ folderName }}-content-color-default, var(--spectrum-{{ folderName }}-content-color-default)));
1616

1717
&.spectrum-{{ pascalCase name }}--sizeS {}
18-
&,
19-
&.spectrum-{{ pascalCase name }}--sizeM {}
2018
&.spectrum-{{ pascalCase name }}--sizeL {}
2119
&.spectrum-{{ pascalCase name }}--sizeXL {}
2220
}

0 commit comments

Comments
 (0)