feat(button): migrate to Spectrum 2 (#2600)

* refactor(button): spectrum 2 styles and cleanup

Spectrum 2 changes to CSS:
- integrate themes css into main css
- use s2 corner rounding
- use s2 colors

Cleanup items of note:
- make medium size the default
- consolidate and organize focus indicator styles. Some declarations
  were repeated.
- Rename mod for font weight that was referencing a global token instead
  of a component specific name.
- simplify repetitive disabled custom properties
- removed some unused css; static variant declarations at the end of the
  file were being overridden by more specific styles
- remove unused is-selected, emphasized, and quiet classes that are not
  used on this component
- remove the spectrum-Button--fill class. it was already the default.

* fix(button): high contrast - ensure matching color pairs for accent

Ensures that a matching background and foreground color pair is used for
the high contrast colors, for Accent hover, down, and focus. Changes
the content color to HighlightText to ensure contrast when these have a
background set to Highlight.

* docs(button): update documentation and storybook for s2

- Some improvements and additions to the spectrum 2 release notes.
- Updates migration guide notes to include version and dates for the
  previous notes.
- Removes spectrum-Button--sizeM class from examples. Excludes the
  spectrum-Button--sizeM class in the storybook template.
- Removes medium size class from storybook
- Fixes default flex alignment stretching buttons vertically in
  Storybook to the tallest button.

* fix(button): calculate corner rounding to support wrapping design

Calculate corner rounding based on the component height, so that the
rounding looks correct when there is wrapping text.

Otherwise, when the button wraps, it has too much rounding as compared
to the design when using the corner-radius-full token.

* feat(button): outline option removals and use accent as the default

Removes the outline option for the accent and negative variants, and
makes sure that the accent variant is the default.

== outline option removal ==

Per design feedback and updated design spec changelog, the outline
treatment (style) is no longer supported for the Accent and Negative
color variants:

"Outline buttons are no longer available in accent and negative options
— use the filled variant instead"

This removes their CSS, lists the change in the migration notes, and
disables the treatment control for the Accent and Negative stories. It
also removes the outline example in the template for those two stories.

== use accent as the default ==

Use accent styles for the default button when there is no variant class
applied, to match the default defined on the guidelines.

* fix(button): additional s2 style adjustments and organization

- make usage of edge to visual values consistent
- use full corner rounding on icon-only variant, which does not need to
  account for wrapping text
- correct static white secondary outline background color, per PR review
- chore: apply linter formatting

* docs(button): custom mdx docs page

Create an MDX "Docs" page that works as a replacement for the YML docs
pages, and covers the important Button options from there and the
guidelines.

Adds the tag "is-hidden-story" for excluding Storybook sidebar items.

* chore(button): add changeset

* build(button): use beta version of commons dependency

Since the commons version on main was updated to 10.0, the Button
started building with the wrong version of commons when importing
basebutton.css and listing mods that have been removed in the version
of commons in the spectrum-two branch.

* chore(button): clear up linter warnings

Fixes warnings and errors from stylelint and eslint.

* fix(button): correct focus indicator rounding and basebutton mod

The focus indicator rounding needed an additional calc in order to
have the correct rounding.

While testing --mod-button-focus-ring-gap and some other mods, it was
also noticed that a declaration being imported from basebutton was
causing some of the mod names to be different and the mod to not work
correctly (basebutton is generating a selector for the margin of
.spectrum-Button:focus-visible::after).

Author: jawinn

.changeset/nine-kings-repair.md

@@ -0,0 +1,15 @@
+---
+"@spectrum-css/button": major
+---
+
+#### Spectrum 2 migration
+Button now uses Spectrum 2 tokens and specifications, which includes many color changes to all variants. A few other notable changes:
+- Outline buttons are no longer available in accent and negative options — use the filled variant instead.
+- Medium size is now the default. The class `.spectrum-Button--sizeM` is now unnecessary for this size, and has been removed.
+- The `.spectrum-Button--fill` class is no longer needed and has been removed.
+
+The following `--mod` custom properties have been renamed:
+- `--mod-line-height-100` has been renamed to `--mod-button-line-height`
+- `--mod-sans-font-family-stack` has been renamed to `--mod-button-font-family`
+- `--mod-animation-duration-100` has been renamed to `--mod-button-animation-duration`
+- `--mod-bold-font-weight` has been renamed to `--mod-button-font-weight`

.storybook/assets/base.css

@@ -39,6 +39,14 @@ body {
 	background-color: var(--spectrum-background-layer-1-color);
 }
 
+.spectrum .spectrum-examples-static-black {
+	background: var(--spectrum-examples-gradient-static-black);
+}
+
+.spectrum .spectrum-examples-static-white {
+	background: var(--spectrum-examples-gradient-static-white)
+}
+
 /* Hide the SVG elements that only include references */
 svg:has(symbol):not(:has(use)) {
 	display: none;

.storybook/manager.js

@@ -66,7 +66,7 @@ addons.setConfig({
 	sidebar: {
 		showRoots: false,
 		filters: {
-			patterns: (item) => !(item.id.includes('forced-colors') || item.tags.includes('foundation')),
+			patterns: (item) => !item.id.includes('forced-colors') && ['foundation','is-hidden-story'].every((tag) => !item.tags.includes(tag)),
 		}
 	},
 });

components/button/dist/metadata.json

@@ -6,53 +6,38 @@
     ".spectrum-Button .spectrum-Icon",
     ".spectrum-Button .spectrum-Icon + .spectrum-Button-label",
     ".spectrum-Button .spectrum-ProgressCircle",
-    ".spectrum-Button--noWrap .spectrum-Button-label",
     ".spectrum-Button--sizeL",
     ".spectrum-Button--sizeS",
+    ".spectrum-Button--sizeS.spectrum-Button--iconOnly",
     ".spectrum-Button--sizeXL",
     ".spectrum-Button-label",
     ".spectrum-Button-label:empty",
     ".spectrum-Button.is-disabled",
+    ".spectrum-Button.is-focused",
     ".spectrum-Button.is-focused:after",
     ".spectrum-Button.is-pending",
     ".spectrum-Button.is-pending .spectrum-Button-label",
     ".spectrum-Button.is-pending .spectrum-Icon",
     ".spectrum-Button.is-pending .spectrum-ProgressCircle",
-    ".spectrum-Button.is-selected",
-    ".spectrum-Button.is-selected.spectrum-Button--emphasized",
     ".spectrum-Button.spectrum-Button--accent",
-    ".spectrum-Button.spectrum-Button--accent.spectrum-Button--fill",
-    ".spectrum-Button.spectrum-Button--accent.spectrum-Button--outline",
+    ".spectrum-Button.spectrum-Button--accent .spectrum-Button-label",
     ".spectrum-Button.spectrum-Button--iconOnly",
     ".spectrum-Button.spectrum-Button--iconOnly .spectrum-Icon",
     ".spectrum-Button.spectrum-Button--iconOnly:after",
     ".spectrum-Button.spectrum-Button--negative",
-    ".spectrum-Button.spectrum-Button--negative.spectrum-Button--outline",
     ".spectrum-Button.spectrum-Button--outline",
     ".spectrum-Button.spectrum-Button--primary",
     ".spectrum-Button.spectrum-Button--primary.spectrum-Button--outline",
-    ".spectrum-Button.spectrum-Button--quiet",
     ".spectrum-Button.spectrum-Button--secondary",
     ".spectrum-Button.spectrum-Button--secondary.spectrum-Button--outline",
-    ".spectrum-Button.spectrum-Button--secondary:not(.spectrum-Button--outline)",
     ".spectrum-Button.spectrum-Button--staticBlack",
-    ".spectrum-Button.spectrum-Button--staticBlack.is-selected",
     ".spectrum-Button.spectrum-Button--staticBlack.spectrum-Button--outline",
-    ".spectrum-Button.spectrum-Button--staticBlack.spectrum-Button--outline:not(.spectrum-Button--secondary)",
-    ".spectrum-Button.spectrum-Button--staticBlack.spectrum-Button--quiet",
     ".spectrum-Button.spectrum-Button--staticBlack.spectrum-Button--secondary",
     ".spectrum-Button.spectrum-Button--staticBlack.spectrum-Button--secondary.spectrum-Button--outline",
-    ".spectrum-Button.spectrum-Button--staticBlack.spectrum-Button--secondary:not(.spectrum-Button--outline)",
     ".spectrum-Button.spectrum-Button--staticWhite",
-    ".spectrum-Button.spectrum-Button--staticWhite.is-selected",
-    ".spectrum-Button.spectrum-Button--staticWhite.spectrum-Button--accent",
     ".spectrum-Button.spectrum-Button--staticWhite.spectrum-Button--outline",
-    ".spectrum-Button.spectrum-Button--staticWhite.spectrum-Button--outline.spectrum-Button--secondary",
-    ".spectrum-Button.spectrum-Button--staticWhite.spectrum-Button--outline:not(.spectrum-Button--secondary)",
-    ".spectrum-Button.spectrum-Button--staticWhite.spectrum-Button--quiet",
     ".spectrum-Button.spectrum-Button--staticWhite.spectrum-Button--secondary",
     ".spectrum-Button.spectrum-Button--staticWhite.spectrum-Button--secondary.spectrum-Button--outline",
-    ".spectrum-Button.spectrum-Button--staticWhite.spectrum-Button--secondary:not(.spectrum-Button--outline)",
     ".spectrum-Button::-moz-focus-inner",
     ".spectrum-Button:active",
     ".spectrum-Button:after",
@@ -61,14 +46,15 @@
     ".spectrum-Button:focus-visible",
     ".spectrum-Button:focus-visible:after",
     ".spectrum-Button:hover",
+    ".spectrum-Button:not(.spectrum-Button--primary, .spectrum-Button--negative, .spectrum-Button--secondary, .spectrum-Button--staticBlack, .spectrum-Button--staticWhite)",
+    ".spectrum-Button:not(.spectrum-Button--primary, .spectrum-Button--negative, .spectrum-Button--secondary, .spectrum-Button--staticBlack, .spectrum-Button--staticWhite) .spectrum-Button-label",
     ".spectrum-Button[pending]",
     ".spectrum-Button[pending] .spectrum-Button-label",
     ".spectrum-Button[pending] .spectrum-Icon",
     ".spectrum-Button[pending] .spectrum-ProgressCircle",
     "a.spectrum-Button"
   ],
   "modifiers": [
-    "--mod-bold-font-weight",
     "--mod-button-animation-duration",
     "--mod-button-background-color-default",
     "--mod-button-background-color-disabled",
@@ -91,29 +77,25 @@
     "--mod-button-edge-to-text",
     "--mod-button-edge-to-visual",
     "--mod-button-edge-to-visual-only",
-    "--mod-button-focus-indicator-gap",
     "--mod-button-focus-ring-border-radius",
     "--mod-button-focus-ring-color",
     "--mod-button-focus-ring-gap",
     "--mod-button-focus-ring-thickness",
     "--mod-button-font-family",
     "--mod-button-font-size",
+    "--mod-button-font-weight",
     "--mod-button-height",
     "--mod-button-icon-margin-block-start",
     "--mod-button-line-height",
     "--mod-button-margin-block",
     "--mod-button-margin-left",
     "--mod-button-margin-right",
-    "--mod-button-max-inline-size",
     "--mod-button-min-width",
     "--mod-button-padding-label-to-icon",
-    "--mod-button-static-content-color",
     "--mod-button-text-align",
     "--mod-button-text-align-with-icon",
     "--mod-button-top-to-icon",
-    "--mod-button-top-to-text",
-    "--mod-focus-indicator-gap",
-    "--mod-static-black-focus-indicator-color"
+    "--mod-button-top-to-text"
   ],
   "component": [
     "--spectrum-button-animation-duration",
@@ -146,21 +128,14 @@
     "--spectrum-button-focus-ring-gap",
     "--spectrum-button-focus-ring-thickness",
     "--spectrum-button-font-size",
+    "--spectrum-button-font-weight",
     "--spectrum-button-height",
+    "--spectrum-button-icon-size-difference",
     "--spectrum-button-intended-icon-size",
     "--spectrum-button-line-height",
     "--spectrum-button-min-width",
     "--spectrum-button-minimum-width-multiplier",
     "--spectrum-button-padding-label-to-icon",
-    "--spectrum-button-sized-bottom-to-text",
-    "--spectrum-button-sized-edge-to-text",
-    "--spectrum-button-sized-edge-to-visual",
-    "--spectrum-button-sized-edge-to-visual-only",
-    "--spectrum-button-sized-font-size",
-    "--spectrum-button-sized-height",
-    "--spectrum-button-sized-padding-label-to-icon",
-    "--spectrum-button-sized-top-to-icon",
-    "--spectrum-button-sized-top-to-text",
     "--spectrum-button-top-to-icon",
     "--spectrum-button-top-to-text",
     "--spectrum-button-top-to-text-extra-large",
@@ -173,15 +148,6 @@
     "--spectrum-accent-background-color-down",
     "--spectrum-accent-background-color-hover",
     "--spectrum-accent-background-color-key-focus",
-    "--spectrum-accent-color-1000",
-    "--spectrum-accent-color-1100",
-    "--spectrum-accent-color-200",
-    "--spectrum-accent-color-300",
-    "--spectrum-accent-color-900",
-    "--spectrum-accent-content-color-default",
-    "--spectrum-accent-content-color-down",
-    "--spectrum-accent-content-color-hover",
-    "--spectrum-accent-content-color-key-focus",
     "--spectrum-animation-duration-100",
     "--spectrum-black",
     "--spectrum-bold-font-weight",
@@ -209,6 +175,7 @@
     "--spectrum-component-top-to-workflow-icon-200",
     "--spectrum-component-top-to-workflow-icon-300",
     "--spectrum-component-top-to-workflow-icon-75",
+    "--spectrum-corner-radius-full",
     "--spectrum-disabled-background-color",
     "--spectrum-disabled-border-color",
     "--spectrum-disabled-content-color",
@@ -233,9 +200,6 @@
     "--spectrum-gray-25",
     "--spectrum-gray-300",
     "--spectrum-gray-400",
-    "--spectrum-gray-50",
-    "--spectrum-gray-500",
-    "--spectrum-gray-600",
     "--spectrum-gray-800",
     "--spectrum-gray-900",
     "--spectrum-icon-block-size",
@@ -244,15 +208,6 @@
     "--spectrum-negative-background-color-down",
     "--spectrum-negative-background-color-hover",
     "--spectrum-negative-background-color-key-focus",
-    "--spectrum-negative-color-1000",
-    "--spectrum-negative-color-1100",
-    "--spectrum-negative-color-200",
-    "--spectrum-negative-color-300",
-    "--spectrum-negative-color-900",
-    "--spectrum-negative-content-color-default",
-    "--spectrum-negative-content-color-down",
-    "--spectrum-negative-content-color-hover",
-    "--spectrum-negative-content-color-key-focus",
     "--spectrum-neutral-background-color-default",
     "--spectrum-neutral-background-color-down",
     "--spectrum-neutral-background-color-hover",
@@ -261,10 +216,6 @@
     "--spectrum-neutral-content-color-down",
     "--spectrum-neutral-content-color-hover",
     "--spectrum-neutral-content-color-key-focus",
-    "--spectrum-neutral-subdued-background-color-default",
-    "--spectrum-neutral-subdued-background-color-down",
-    "--spectrum-neutral-subdued-background-color-hover",
-    "--spectrum-neutral-subdued-background-color-key-focus",
     "--spectrum-progress-circle-thickness-medium",
     "--spectrum-sans-font-family-stack",
     "--spectrum-static-black-focus-indicator-color",
@@ -273,18 +224,19 @@
     "--spectrum-text-to-visual-200",
     "--spectrum-text-to-visual-300",
     "--spectrum-text-to-visual-75",
-    "--spectrum-transparent-black-1000",
+    "--spectrum-transparent-black-100",
+    "--spectrum-transparent-black-200",
+    "--spectrum-transparent-black-25",
     "--spectrum-transparent-black-300",
     "--spectrum-transparent-black-400",
-    "--spectrum-transparent-black-500",
-    "--spectrum-transparent-black-600",
-    "--spectrum-transparent-black-700",
+    "--spectrum-transparent-black-800",
     "--spectrum-transparent-black-900",
-    "--spectrum-transparent-white-1000",
+    "--spectrum-transparent-white-100",
+    "--spectrum-transparent-white-200",
+    "--spectrum-transparent-white-25",
     "--spectrum-transparent-white-300",
     "--spectrum-transparent-white-400",
-    "--spectrum-transparent-white-500",
-    "--spectrum-transparent-white-600",
+    "--spectrum-transparent-white-800",
     "--spectrum-transparent-white-900",
     "--spectrum-white",
     "--spectrum-workflow-icon-size-100",
@@ -314,6 +266,7 @@
     "--highcontrast-button-content-color-disabled",
     "--highcontrast-button-content-color-down",
     "--highcontrast-button-content-color-focus",
-    "--highcontrast-button-content-color-hover"
+    "--highcontrast-button-content-color-hover",
+    "--highcontrast-button-focus-ring-color"
   ]
 }