Skip to content

Commit 5f1751c

Browse files
authored
feat: update postcss tooling (#3527)
By updating the postcss-preset-env to the latest breaking change version, output for this component no longer injects the .js-focus-within and '[focus-within]` selectors for the focus-within polyfill. Changes appear in: clearbutton, assetlist, slider, dial, menu.
1 parent e676eb5 commit 5f1751c

File tree

21 files changed

+804
-912
lines changed

21 files changed

+804
-912
lines changed

.changeset/dirty-gorillas-warn.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
"@spectrum-css/clearbutton": minor
3+
"@spectrum-css/assetlist": minor
4+
"@spectrum-css/slider": minor
5+
"@spectrum-css/dial": minor
6+
"@spectrum-css/menu": minor
7+
---
8+
9+
By updating the postcss-preset-env to the latest breaking change version, output for this component no longer injects the `.js-focus-within` and '[focus-within]` selectors for the focus-within polyfill. As this feature is not used in the SWC consumption, risk to the end user for this removal is low.

.changeset/silent-pandas-film.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
"@spectrum-tools/stylelint-no-unknown-custom-properties": patch
3+
"@spectrum-tools/stylelint-no-unused-custom-properties": patch
4+
"@spectrum-tools/postcss-add-theming-layer": patch
5+
"@spectrum-tools/stylelint-theme-alignment": patch
6+
"@spectrum-tools/stylelint-no-missing-var": patch
7+
"@spectrum-css/bundle": patch
8+
"@spectrum-css/preview": patch
9+
---
10+
11+
Minor dependency updates to align with the larger project.

.storybook/main.js

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import fs from "fs";
2-
import path from "path";
3-
import remarkGfm from "remark-gfm";
1+
import fs from "node:fs";
2+
import path from "node:path";
3+
import remarkGfm from 'remark-gfm';
44

55
// Get a list of all the folders in the components directory
66
const componentDir = path.resolve(__dirname, "../components");
@@ -104,7 +104,17 @@ export default {
104104
devSourcemap: configType === "DEVELOPMENT",
105105
},
106106
resolve: {
107-
alias: components.map(component => ({ find: `@spectrum-css/${component}`, replacement: path.resolve(__dirname, `../components/${component}`) })),
107+
alias: [
108+
...components.map(component => ({ find: `@spectrum-css/${component}`, replacement: path.resolve(__dirname, `../components/${component}`) })),
109+
{
110+
find: `@spectrum-css/tokens`,
111+
replacement: path.resolve(__dirname, `../tokens`),
112+
},
113+
{
114+
find: `@spectrum-css/ui-icons`,
115+
replacement: path.resolve(__dirname, `../ui-icons`),
116+
},
117+
],
108118
}
109119
});
110120
},

.storybook/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"@adobe/spectrum-css-workflow-icons": "^1.5.4",
4343
"@spectrum-css/bundle": "1.0.0",
4444
"@spectrum-css/tokens": "16.0.1",
45-
"@spectrum-css/tokens-legacy": "npm:@spectrum-css/tokens@^15.2.0",
45+
"@spectrum-css/tokens-legacy": "npm:@spectrum-css/tokens@^15.0.0",
4646
"@spectrum-css/ui-icons": "1.1.2"
4747
},
4848
"devDependencies": {
@@ -70,7 +70,7 @@
7070
"lodash-es": "^4.17.21",
7171
"npm-registry-fetch": "^18.0.2",
7272
"postcss": "^8.5.3",
73-
"prettier": "^3.4.2",
73+
"prettier": "^3.5.3",
7474
"react": "^18.3.1",
7575
"react-dom": "^18.3.1",
7676
"react-syntax-highlighter": "^15.6.1",

.storybook/postcss.config.js

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
/*!
2+
* Copyright 2024 Adobe. All rights reserved.
3+
*
4+
* This file is licensed to you under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License. You may obtain a copy
6+
* of the License at http://www.apache.org/licenses/LICENSE-2.0
7+
*
8+
* Unless required by applicable law or agreed to in writing, software distributed under
9+
* the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS
10+
* OF ANY KIND, either express or implied. See the License for the specific language
11+
* governing permissions and limitations under the License.
12+
*/
13+
14+
module.exports = (options) => require("../postcss.config.js")({
15+
...options,
16+
resolveImports: false,
17+
env: "production",
18+
map: false,
19+
lint: false,
20+
additionalPlugins: {
21+
"@csstools/postcss-bundler": {},
22+
},
23+
});

components/assetlist/dist/metadata.json

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,12 @@
11
{
22
"sourceFile": "index.css",
33
"selectors": [
4-
".js-focus-within .spectrum-AssetList-item.is-focused[focus-within]",
5-
".js-focus-within .spectrum-AssetList-item.is-focused[focus-within]:before",
6-
".js-focus-within .spectrum-AssetList-item[focus-within]:focus-visible",
7-
".js-focus-within .spectrum-AssetList-item[focus-within]:focus-visible:before",
84
".spectrum-AssetList",
95
".spectrum-AssetList-item",
106
".spectrum-AssetList-item .spectrum-AssetList-itemThumbnail",
117
".spectrum-AssetList-item.is-branch .spectrum-AssetList-itemChildIndicator",
128
".spectrum-AssetList-item.is-focused:focus-within",
139
".spectrum-AssetList-item.is-focused:focus-within:before",
14-
".spectrum-AssetList-item.is-focused[focus-within].js-focus-within",
15-
".spectrum-AssetList-item.is-focused[focus-within].js-focus-within:before",
1610
".spectrum-AssetList-item.is-navigated",
1711
".spectrum-AssetList-item.is-navigated:focus",
1812
".spectrum-AssetList-item.is-navigated:hover",
@@ -30,8 +24,6 @@
3024
".spectrum-AssetList-itemChildIndicator",
3125
".spectrum-AssetList-itemLabel",
3226
".spectrum-AssetList-itemSelector",
33-
".spectrum-AssetList-item[focus-within]:focus-visible.js-focus-within",
34-
".spectrum-AssetList-item[focus-within]:focus-visible.js-focus-within:before",
3527
".spectrum-AssetList:dir(rtl)",
3628
"[dir=\"rtl\"] .spectrum-AssetList"
3729
],

components/clearbutton/dist/metadata.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
{
22
"sourceFile": "index.css",
33
"selectors": [
4-
".js-focus-within .spectrum-ClearButton:not(:disabled)[focus-within]",
5-
".js-focus-within .spectrum-ClearButton:not(:disabled)[focus-within] .spectrum-ClearButton-fill",
64
".spectrum-ClearButton",
75
".spectrum-ClearButton > .spectrum-Icon",
86
".spectrum-ClearButton--overBackground:focus-visible",
@@ -24,9 +22,7 @@
2422
".spectrum-ClearButton:not(:disabled):focus-within",
2523
".spectrum-ClearButton:not(:disabled):focus-within .spectrum-ClearButton-fill",
2624
".spectrum-ClearButton:not(:disabled):hover",
27-
".spectrum-ClearButton:not(:disabled):hover .spectrum-ClearButton-fill",
28-
".spectrum-ClearButton:not(:disabled)[focus-within].js-focus-within",
29-
".spectrum-ClearButton:not(:disabled)[focus-within].js-focus-within .spectrum-ClearButton-fill"
25+
".spectrum-ClearButton:not(:disabled):hover .spectrum-ClearButton-fill"
3026
],
3127
"modifiers": [
3228
"--mod-clear-button-background-color",

components/dial/dist/metadata.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
{
22
"sourceFile": "index.css",
33
"selectors": [
4-
".js-focus-within .spectrum-Dial-handle[focus-within]",
5-
".js-focus-within .spectrum-Dial-handle[focus-within]:after",
64
".spectrum-Dial",
75
".spectrum-Dial-controls",
86
".spectrum-Dial-controls:after",
@@ -20,8 +18,6 @@
2018
".spectrum-Dial-handle:focus-within:after",
2119
".spectrum-Dial-handle:hover",
2220
".spectrum-Dial-handle:hover:after",
23-
".spectrum-Dial-handle[focus-within].js-focus-within",
24-
".spectrum-Dial-handle[focus-within].js-focus-within:after",
2521
".spectrum-Dial-input",
2622
".spectrum-Dial-input:focus",
2723
".spectrum-Dial-label",

components/menu/dist/metadata.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
22
"sourceFile": "index.css",
33
"selectors": [
4-
".js-focus-within .spectrum-Menu .spectrum-Menu-item--collapsible.is-open[focus-within]",
54
".spectrum-Menu",
65
".spectrum-Menu .spectrum-Menu-backIcon",
76
".spectrum-Menu .spectrum-Menu-checkmark",
@@ -129,7 +128,6 @@
129128
".spectrum-Menu.is-selectable .spectrum-Menu-item.is-selected",
130129
".spectrum-Menu.is-selectableMultiple .spectrum-Menu-item",
131130
".spectrum-Menu.is-selectableMultiple .spectrum-Menu-itemCheckbox",
132-
".spectrum-Menu.js-focus-within .spectrum-Menu-item--collapsible.is-open[focus-within]",
133131
".spectrum-Menu.spectrum-Menu--sizeL",
134132
".spectrum-Menu.spectrum-Menu--sizeS",
135133
".spectrum-Menu.spectrum-Menu--sizeXL",

components/slider/dist/metadata.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
22
"sourceFile": "index.css",
33
"selectors": [
4-
".js-focus-within .spectrum-Slider:not(.is-disabled, .spectrum-Slider--filled, .spectrum-Slider--range) .spectrum-Slider-controls[focus-within]",
54
".spectrum-Slider",
65
".spectrum-Slider .spectrum-Slider-handle.is-focused:before",
76
".spectrum-Slider--filled .spectrum-Slider-track:first-child:before",
@@ -94,7 +93,6 @@
9493
".spectrum-Slider:not(.is-disabled, .spectrum-Slider--filled, .spectrum-Slider--range) .spectrum-Slider-controls:active",
9594
".spectrum-Slider:not(.is-disabled, .spectrum-Slider--filled, .spectrum-Slider--range) .spectrum-Slider-controls:focus-within",
9695
".spectrum-Slider:not(.is-disabled, .spectrum-Slider--filled, .spectrum-Slider--range) .spectrum-Slider-controls:hover",
97-
".spectrum-Slider:not(.is-disabled, .spectrum-Slider--filled, .spectrum-Slider--range).js-focus-within .spectrum-Slider-controls[focus-within]",
9896
".spectrum-Slider:not(.spectrum-Slider--sideLabel) .spectrum-Slider-labelContainer + .spectrum-Slider-controls:has(.spectrum-Slider-ramp)",
9997
"[dir=\"rtl\"] .spectrum-Slider",
10098
"[dir=\"rtl\"] .spectrum-Slider .spectrum-Slider-handle:before"

0 commit comments

Comments
 (0)