You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Migrates the Picker component to Spectrum 2, based on the updated Figma specs.
- Integrate themes CSS files into index.css
- Uses new S2 tokens for field width and corner rounding
- Add down state with new calculated perspective
- The top to alert icon in Spectrum 2 now uses the
component-top-to-workflow-icon-* tokens as defined on the design.
- Adds the CJK line-height token defined on the design specs.
- Uses border-width-200 instead of border-width-100
* fix(picker): use correct spacing between icons and value text
The spacing between alert icon and disclosure icon was incorrect
because it was being overridden by a selector that shouldn't have been
affecting this scenario (which was using the subsequent-sibling
combinator ~). Some mods around the spacing for the three different
types of icons were also not working as expected.
Fixes this spacing and clarifies which spacing is which. Renames the mod
that applies to the optional workflow icon to the left of the value.
Simplifies quiet styles by changing custom property values instead of
adding extra styles.
* feat(picker): storybook - expanded and improved chromatic template
Expands the Chromatic-only template in Storybook to increase coverage
of different options.
Organizes the stories into sections using the formatting and typography
previously established with Action button. States in each section are
based on the grid of options in the Desktop S2 design Figma, with some
additions such as the loading state. And the Switch examples from the
existing template.
Removes the "Open" story which is now covered in the Chromatic template.
Adds missing icon (to left of value/placeholder text) option to
Storybook, along with VRT coverage.
Improves display of Popover within these different contexts; fixes how
it is aligned on the side label example. Changes the side label example
to use flex row instead of using inline-block which could wrap as the
screen shrunk.
=== Other Storybook fixes and additions ===
- Adds aria-labelledby and unique ids to make sure the label is associated
with the Picker.
- Includes downstate dimension capture
- Popover does not show when in the loading state (per design feedback)
- Makes sure HelpText appears below the Picker when using side label, by
adjusting its wrapper markup.
- Adds conditional controls to disabled and loading states, per the PR
feedback that disabled + loading should not be a possible combo.
0 commit comments