Skip to content

Commit 4e5e9cb

Browse files
committed
feat(card): update styles to use refreshed token
1 parent 40d3bf0 commit 4e5e9cb

File tree

5 files changed

+70
-34
lines changed

5 files changed

+70
-34
lines changed

.changeset/spotty-bats-deny.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
---
2+
"@spectrum-css/card": major
3+
---
4+
5+
Previously:
6+
7+
```css
8+
.spectrum-Card.is-selected::before {
9+
background-color: rgba(
10+
var(
11+
--mod-card-selected-background-color-rgb,
12+
var(--spectrum-card-selected-background-color-rgb)
13+
),
14+
var(--spectrum-card-selected-background-opacity)
15+
);
16+
}
17+
```
18+
19+
Styles now use `--spectrum-card-selection-background-color` which maps to a transparent global property of `--spectrum-transparent-(black|white)-600` depending on color context.
20+
21+
Updated:
22+
23+
```css
24+
.spectrum-Card.is-selected::before {
25+
background-color: var(
26+
--mod-card-background-color-selected,
27+
var(--spectrum-card-selection-background-color)
28+
);
29+
}
30+
```
31+
32+
#### Removed/replaced properties
33+
34+
- `--mod-card-selected-background-color-rgb`. Use `--mod-card-background-color-selected` to override the selected background color.
35+
- `--mod-card-content-margin-top-quiet`. Use `--mod-card-content-margin-top` with appropriate selectors to override.
36+
- `--mod-card-minimum-width-quiet`. Use `--mod-card-minimum-width` with appropriate selectors to override.
37+
- `--mod-card-actions-background-color-rgb`. No replacement, using token value `--spectrum-card-selection-background-color` directly.
38+
- `--mod-card-actions-background-color-opacity`. No replacement, using token value `--spectrum-card-selection-background-color` directly.

.markdownlint.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"extends": "markdownlint/style/prettier",
33
"first-line-h1": false,
4-
"no-inline-html": false,
4+
"no-inline-html": false,
55
"no-bare-urls": false,
66
"no-duplicate-heading": {
77
"siblings_only": true

.prettierignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
**/.svn
44
**/.hg
55
**/node_modules
6+
yarn.lock
67

78
# Compiled and generated files
89
dist

components/card/dist/metadata.json

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
".spectrum-Card.is-drop-target",
5656
".spectrum-Card.is-focused .spectrum-Card-actions",
5757
".spectrum-Card.is-focused .spectrum-Card-quickActions",
58+
".spectrum-Card.is-selected",
5859
".spectrum-Card.is-selected .spectrum-Card-actions",
5960
".spectrum-Card.is-selected .spectrum-Card-quickActions",
6061
".spectrum-Card.is-selected:before",
@@ -74,8 +75,6 @@
7475
],
7576
"modifiers": [
7677
"--mod-animation-duration-100",
77-
"--mod-card-actions-background-color-opacity",
78-
"--mod-card-actions-background-color-rgb",
7978
"--mod-card-actions-border-radius",
8079
"--mod-card-actions-drop-shadow-blur",
8180
"--mod-card-actions-drop-shadow-color",
@@ -86,6 +85,7 @@
8685
"--mod-card-animation-duration",
8786
"--mod-card-background-color",
8887
"--mod-card-background-color-hover",
88+
"--mod-card-background-color-selected",
8989
"--mod-card-body-font-color",
9090
"--mod-card-body-font-family",
9191
"--mod-card-body-font-size",
@@ -103,7 +103,6 @@
103103
"--mod-card-border-width",
104104
"--mod-card-content-margin-bottom",
105105
"--mod-card-content-margin-top",
106-
"--mod-card-content-margin-top-quiet",
107106
"--mod-card-corner-radius",
108107
"--mod-card-divider-color",
109108
"--mod-card-focus-indicator-color",
@@ -116,7 +115,6 @@
116115
"--mod-card-horizontal-body-padding",
117116
"--mod-card-horizontal-preview-padding",
118117
"--mod-card-minimum-width",
119-
"--mod-card-minimum-width-quiet",
120118
"--mod-card-preview-background-color",
121119
"--mod-card-preview-background-color-hover",
122120
"--mod-card-preview-border-width-selected",
@@ -134,8 +132,6 @@
134132
"--mod-overlay-animation-duration"
135133
],
136134
"component": [
137-
"--spectrum-card-actions-background-color-opacity",
138-
"--spectrum-card-actions-background-color-rgb",
139135
"--spectrum-card-actions-border-radius",
140136
"--spectrum-card-actions-drop-shadow-blur",
141137
"--spectrum-card-actions-drop-shadow-color",
@@ -172,7 +168,7 @@
172168
"--spectrum-card-preview-minimum-height",
173169
"--spectrum-card-selected-background-color-rgb",
174170
"--spectrum-card-selected-background-opacity",
175-
"--spectrum-card-selection-background-color-opacity",
171+
"--spectrum-card-selection-background-color",
176172
"--spectrum-card-selection-background-size",
177173
"--spectrum-card-subtitle-padding-right",
178174
"--spectrum-card-title-font-color",
@@ -202,7 +198,6 @@
202198
"--spectrum-focus-indicator-color",
203199
"--spectrum-focus-indicator-thickness",
204200
"--spectrum-gray-100",
205-
"--spectrum-gray-100-rgb",
206201
"--spectrum-gray-200",
207202
"--spectrum-heading-color",
208203
"--spectrum-heading-line-height",

components/card/index.css

Lines changed: 27 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,13 @@
1212
*/
1313

1414
.spectrum-Card {
15-
--spectrum-card-border-color: var(--spectrum-gray-100);
16-
--spectrum-card-border-color-hover: var(--spectrum-gray-200);
17-
--spectrum-card-divider-color: var(--spectrum-gray-200);
18-
--spectrum-card-preview-background-color: var(--spectrum-gray-100);
19-
--spectrum-card-preview-background-color-hover: var(--spectrum-gray-200);
15+
--spectrum-card-border-color: var(--mod-card-border-color, var(--spectrum-gray-100));
16+
--spectrum-card-border-color-hover: var(--mod-card-border-color-hover, var(--spectrum-gray-200));
17+
--spectrum-card-border-color-selected: var(--mod-card-border-color-selected, var(--spectrum-blue-700));
18+
19+
--spectrum-card-divider-color: var(--mod-card-divider-color, var(--spectrum-gray-200));
20+
--spectrum-card-preview-background-color: var(--mod-card-preview-background-color, var(--mod-card-background-color, var(--spectrum-gray-100)));
21+
--spectrum-card-preview-background-color-hover: var(--mod-card-preview-background-color-hover, var(--mod-card-background-color-hover, var(--spectrum-gray-200)));
2022

2123
/* Default Layout */
2224
--spectrum-card-background-color: var(--mod-card-background-color, var(--spectrum-background-layer-2-color));
@@ -30,7 +32,6 @@
3032

3133
--spectrum-card-border-width: var(--mod-card-border-width, var(--spectrum-border-width-100));
3234
--spectrum-card-corner-radius: var(--mod-card-corner-radius, var(--spectrum-corner-radius-100));
33-
--spectrum-card-border-color-selected: var(--mod-card-border-color-selected, var(--spectrum-blue-700));
3435

3536
/* Typography */
3637
--spectrum-card-title-font-family: var(--mod-card-title-font-family, var(--spectrum-sans-font-family-stack));
@@ -52,9 +53,6 @@
5253
--spectrum-card-actions-size: var(--mod-card-actions-size, var(--spectrum-card-selection-background-size));
5354
--spectrum-card-actions-border-radius: var(--mod-card-actions-border-radius, var(--spectrum-corner-radius-100));
5455

55-
/* TODO update to --spectrum-card-selection-background-color token once an RGB stripped value is available */
56-
--spectrum-card-actions-background-color-rgb: var(--mod-card-actions-background-color-rgb, var(--spectrum-gray-100-rgb));
57-
--spectrum-card-actions-background-color-opacity: var(--mod-card-actions-background-color-opacity, var(--spectrum-card-selection-background-color-opacity));
5856
--spectrum-card-actions-drop-shadow-color: var(--mod-card-actions-drop-shadow-color, var(--spectrum-drop-shadow-color));
5957
--spectrum-card-actions-drop-shadow-x: var(--mod-card-actions-drop-shadow-x, var(--spectrum-drop-shadow-x));
6058
--spectrum-card-actions-drop-shadow-y: var(--mod-card-actions-drop-shadow-y, var(--spectrum-drop-shadow-y));
@@ -74,8 +72,7 @@
7472
--spectrum-card-horizontal-preview-padding: var(--mod-card-horizontal-preview-padding, var(--spectrum-spacing-200));
7573

7674
&.spectrum-Card--quiet {
77-
--mod-card-minimum-width: var(--mod-card-minimum-width-quiet);
78-
--mod-card-content-margin-top: var(--mod-card-content-margin-top-quiet, var(--spectrum-spacing-100));
75+
--spectrum-card-content-margin-top: var(--spectrum-spacing-100);
7976
}
8077

8178
&.spectrum-Card--gallery {
@@ -93,7 +90,7 @@
9390

9491
border: var(--spectrum-card-border-width) solid transparent;
9592
border-radius: var(--spectrum-card-corner-radius);
96-
border-color: var(--mod-card-border-color, var(--spectrum-card-border-color));
93+
border-color: var(--spectrum-card-border-color);
9794

9895
background-color: var(--spectrum-card-background-color);
9996

@@ -143,11 +140,16 @@
143140
}
144141

145142
&:hover {
146-
--mod-card-border-color: var(--mod-card-border-color-hover, var(--spectrum-card-border-color-hover));
143+
--mod-card-border-color: var(--spectrum-card-border-color-hover);
147144
}
148145

149-
&.is-selected::before {
150-
background-color: rgba(var(--mod-card-selected-background-color-rgb, var(--spectrum-card-selected-background-color-rgb)), var(--spectrum-card-selected-background-opacity));
146+
&.is-selected {
147+
--mod-card-border-color: var(--spectrum-card-border-color-selected);
148+
149+
&::before {
150+
/* @deprecated --mod-card-selected-background-color-rgb. Use --mod-card-background-color-selected instead. */
151+
background-color: var(--mod-card-background-color-selected, var(--spectrum-card-selection-background-color));
152+
}
151153
}
152154

153155
&.is-drop-target {
@@ -177,7 +179,7 @@
177179
inline-size: var(--spectrum-card-actions-size);
178180
block-size: var(--spectrum-card-actions-size);
179181
border-radius: var(--spectrum-card-actions-border-radius);
180-
background-color: rgba(var(--spectrum-card-actions-background-color-rgb), var(--spectrum-card-actions-background-color-opacity));
182+
background-color: var(--spectrum-card-selection-background-color);
181183

182184
inset-inline-start: calc(var(--spectrum-card-actions-spacing) - var(--spectrum-card-border-width));
183185
inset-block-start: calc(var(--spectrum-card-actions-spacing) - var(--spectrum-card-border-width));
@@ -218,8 +220,8 @@
218220
background-size: cover;
219221
background-position: center center;
220222

221-
background-color: var(--mod-card-preview-background-color, var(--spectrum-card-preview-background-color));
222-
border-block-end-color: var(--mod-card-border-color, var(--spectrum-card-border-color));
223+
background-color: var(--spectrum-card-preview-background-color);
224+
border-block-end-color: var(--spectrum-card-border-color);
223225
}
224226

225227
.spectrum-Card .spectrum-Divider {
@@ -290,7 +292,7 @@
290292

291293
color: var(--spectrum-card-body-font-color);
292294
line-height: var(--spectrum-card-body-line-height);
293-
border-block-start: var(--spectrum-card-border-width) solid var(--mod-card-divider-color, var(--spectrum-card-divider-color));
295+
border-block-start: var(--spectrum-card-border-width) solid var(--spectrum-card-divider-color);
294296
}
295297

296298
.spectrum-Card-header {
@@ -342,7 +344,7 @@
342344

343345
.spectrum-Card-preview {
344346
border-radius: var(--spectrum-card-corner-radius);
345-
background-color: var(--mod-card-preview-background-color, var(--mod-card-background-color, var(--spectrum-card-preview-background-color)));
347+
background-color: var(--spectrum-card-preview-background-color);
346348
min-block-size: var(--mod-card-preview-minimum-height, var(--spectrum-card-preview-minimum-height));
347349
inline-size: 100%;
348350
flex: 1;
@@ -384,7 +386,7 @@
384386
}
385387

386388
&:hover .spectrum-Card-preview {
387-
background-color: var(--mod-card-preview-background-color-hover, var(--mod-card-background-color-hover, var(--spectrum-card-preview-background-color-hover)));
389+
background-color: var(--spectrum-card-preview-background-color-hover);
388390
}
389391

390392
&.is-drop-target {
@@ -394,7 +396,7 @@
394396

395397
.spectrum-Card-preview {
396398
transition: none;
397-
background-color: var(--mod-card-preview-background-color, var(--mod-card-background-color, var(--spectrum-card-preview-background-color)));
399+
background-color: var(--spectrum-card-preview-background-color);
398400
}
399401

400402
.spectrum-Card-preview::before {
@@ -422,7 +424,7 @@
422424
flex-direction: row;
423425

424426
&:hover .spectrum-Card-preview {
425-
border-color: var(--mod-card-border-color-hover, var(--spectrum-card-border-color-hover));
427+
--mod-card-border-color: var(--spectrum-card-border-color-hover);
426428
}
427429

428430
.spectrum-Card-preview {
@@ -438,8 +440,8 @@
438440
border-end-end-radius: 0;
439441

440442
padding: var(--spectrum-card-horizontal-preview-padding);
441-
background-color: var(--mod-card-preview-background-color, var(--spectrum-card-preview-background-color));
442-
border-color: var(--mod-card-border-color, var(--spectrum-card-border-color));
443+
background-color: var(--spectrum-card-preview-background-color);
444+
border-color: var(--spectrum-card-border-color);
443445
}
444446

445447
.spectrum-Card-header,

0 commit comments

Comments
 (0)