Skip to content

Commit 4ab136d

Browse files
feat: adding back disabled state and upping package
1 parent 68220fb commit 4ab136d

File tree

2 files changed

+32
-15
lines changed

2 files changed

+32
-15
lines changed

components/fieldlabel/index.css

Lines changed: 30 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ governing permissions and limitations under the License.
1515
.spectrum--medium {
1616
--spectrum-field-label-top-to-asterisk-small: 8px;
1717
}
18+
1819
.spectrum--large {
1920
--spectrum-field-label-top-to-asterisk-small: 11px;
2021
}
@@ -26,7 +27,7 @@ governing permissions and limitations under the License.
2627
--spectrum-fieldlabel-font-size: var(--spectrum-font-size-75);
2728

2829
--spectrum-fieldlabel-line-height: var(--spectrum-line-height-100);
29-
--spectrum-fieldlabel-CJK-line-height: var(--spectrum-CJK-line-height-100);
30+
--spectrum-fieldlabel-cjk-line-height: var(--spectrum-CJK-line-height-100);
3031

3132
--spectrum-fieldlabel-asterisk-gap: var(--spectrum-field-label-top-to-asterisk-small);
3233
--spectrum-fieldlabel-side-padding-top: var(--spectrum-component-top-to-text-75);
@@ -40,33 +41,35 @@ governing permissions and limitations under the License.
4041
--spectrum-fieldlabel-font-size: var(--spectrum-font-size-75);
4142

4243
--spectrum-fieldlabel-line-height: var(--spectrum-line-height-200);
43-
--spectrum-fieldlabel-CJK-line-height: var(--spectrum-CJK-line-height-200);
44+
--spectrum-fieldlabel-cjk-line-height: var(--spectrum-CJK-line-height-200);
4445

4546
--spectrum-fieldlabel-asterisk-gap: var(--spectrum-field-label-top-to-asterisk-medium);
4647
--spectrum-fieldlabel-side-padding-top: var(--spectrum-component-top-to-text-75);
4748
--spectrum-fieldlabel-side-padding-right: var(--spectrum-spacing-200);
4849
--spectrum-field-label-text-to-asterisk: var(--spectrum-field-label-text-to-asterisk-medium);
4950
}
51+
5052
.spectrum-FieldLabel--sizeL {
5153
--spectrum-fieldlabel-top-to-text: var(--spectrum-component-top-to-text-100);
5254
--spectrum-fieldlabel-bottom-to-text: var(--spectrum-component-bottom-to-text-100);
5355
--spectrum-fieldlabel-font-size: var(--spectrum-font-size-100);
5456

5557
--spectrum-fieldlabel-line-height: var(--spectrum-line-height-100);
56-
--spectrum-fieldlabel-CJK-line-height: var(--spectrum-CJK-line-height-100);
58+
--spectrum-fieldlabel-cjk-line-height: var(--spectrum-CJK-line-height-100);
5759

5860
--spectrum-fieldlabel-asterisk-gap: var(--spectrum-field-label-top-to-asterisk-large);
5961
--spectrum-fieldlabel-side-padding-top: var(--spectrum-component-top-to-text-100);
6062
--spectrum-fieldlabel-side-padding-right: var(--spectrum-spacing-200);
6163
--spectrum-field-label-text-to-asterisk: var(--spectrum-field-label-text-to-asterisk-large);
6264
}
65+
6366
.spectrum-FieldLabel--sizeXL {
6467
--spectrum-fieldlabel-top-to-text: var(--spectrum-component-top-to-text-200);
6568
--spectrum-fieldlabel-bottom-to-text: var(--spectrum-component-bottom-to-text-200);
6669
--spectrum-fieldlabel-font-size: var(--spectrum-font-size-200);
6770

6871
--spectrum-fieldlabel-line-height: var(--spectrum-line-height-200);
69-
--spectrum-fieldlabel-CJK-line-height: var(--spectrum-CJK-line-height-200);
72+
--spectrum-fieldlabel-cjk-line-height: var(--spectrum-CJK-line-height-200);
7073

7174

7275
--spectrum-fieldlabel-asterisk-gap: var(--spectrum-field-label-top-to-asterisk-extra-large);
@@ -97,15 +100,17 @@ governing permissions and limitations under the License.
97100

98101
/* international lang support */
99102
.spectrum-FieldLabel {
103+
100104
&:lang(ja),
101105
&:lang(zh),
102106
&:lang(ko) {
103-
line-height: var(--mod-fieldlabel-CJK-line-height, var(--spectrum-fieldlabel-CJK-line-height));
107+
line-height: var(--mod-fieldlabel-CJK-line-height, var(--spectrum-fieldlabel-cjk-line-height));
104108
}
105109
}
106110

107111
.spectrum-FieldLabel-requiredIcon {
108-
margin-block: 0; /* Previously used this improperly, it doesn't reposition asterisk, just increased top margin on the whole field label var(--spectrum-fieldlabel-asterisk-margin-y) */
112+
margin-block: 0;
113+
/* Previously used this improperly, it doesn't reposition asterisk, just increased top margin on the whole field label var(--spectrum-fieldlabel-asterisk-margin-y) */
109114
margin-inline: var(--mod-fieldlabel-asterisk-gap, var(--spectrum-fieldlabel-asterisk-gap)) 0;
110115
}
111116

@@ -116,23 +121,23 @@ governing permissions and limitations under the License.
116121

117122
& .spectrum-FieldLabel-requiredIcon {
118123
margin-block: var(--mod-field-label-text-to-asterisk, var(--spectrum-field-label-text-to-asterisk)) 0;
119-
margin-inline: var(--mod-fieldlabel-asterisk-gap, var(--spectrum-fieldlabel-asterisk-gap)) 0;
124+
margin-inline: var(--mod-fieldlabel-asterisk-gap, var(--spectrum-fieldlabel-asterisk-gap)) 0;
120125
}
121126
}
122127

123128
.spectrum-FieldLabel--right {
124129
display: inline-block;
125130
text-align: end;
126-
padding-block: var(--mod-fieldlabel-side-padding-to, var(--spectrum-fieldlabel-side-padding-top))0;
131+
padding-block: var(--mod-fieldlabel-side-padding-to, var(--spectrum-fieldlabel-side-padding-top))0;
127132
padding-inline: 0 var(--mod-fieldlabel-side-padding-right), var(--spectrum-fieldlabel-side-padding-right));
128133
}
129134

130135
.spectrum-Form {
131136
/* for /docs/form.html to set field-label inside form */
132-
--spectrum-tableform-border-spacing: 0 var(--spectrum-spacing-300);
137+
--spectrum-tableform-border-spacing: 0 var(--mod-spacing-300, var(--spectrum-spacing-300));
133138
/* matching 20px, missing global token for 20px */
134-
--spectrum-tableform-margin-calc: calc(var(--mod--spacing-300, var(--spectrum-spacing-300)) + var(--mod--spacing-300, var(--spectrum-spacing-200)));
135-
--spectrum-tableform-margin: calc(var(--mod-tableform-margin-calc, var(--spectrum-tableform-margin-calc)) * -1) 0;
139+
--spectrum-tableform-margin-calc: calc(var(--spectrum-spacing-300) + var(--spectrum-spacing-200));
140+
--spectrum-tableform-margin: calc(var(--spectrum-tableform-margin-calc) * -1) 0;
136141

137142
display: table;
138143
border-collapse: separate;
@@ -145,10 +150,22 @@ governing permissions and limitations under the License.
145150
}
146151

147152
.spectrum-Form-itemLabel {
148-
@extend .spectrum-FieldLabel;
149153
display: table-cell;
150154
}
151155

156+
/* disabled state */
157+
158+
.spectrum-FieldLabel,
159+
.spectrum-Form-itemLabel {
160+
&.is-disabled {
161+
color: var(--mod-disabled-content-color, var(--spectrum-disabled-content-color));
162+
163+
.spectrum-FieldLabel-requiredIcon {
164+
color: var(--mod-disabled-content-color, var(--spectrum-disabled-content-color));
165+
}
166+
}
167+
}
168+
152169
.spectrum-Form-itemField {
153170
display: table-cell;
154171
}
@@ -162,7 +179,7 @@ governing permissions and limitations under the License.
162179
display: flex;
163180
flex-direction: column;
164181

165-
& + .spectrum-Form-item {
182+
&+.spectrum-Form-item {
166183
margin-block-start: var(--mod-field-label-top-to-asterisk-small, var(--spectrum-field-label-top-to-asterisk-small));
167184
}
168185
}

components/fieldlabel/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
},
1818
"peerDependencies": {
1919
"@spectrum-css/icon": "^3.0.21",
20-
"@spectrum-css/tokens": "^1.0.1"
20+
"@spectrum-css/tokens": "^1.0.4"
2121
},
2222
"devDependencies": {
2323
"@spectrum-css/checkbox": "^3.1.3",
@@ -28,7 +28,7 @@
2828
"@spectrum-css/radio": "^3.0.24",
2929
"@spectrum-css/stepper": "^3.0.26",
3030
"@spectrum-css/textfield": "^3.2.4",
31-
"@spectrum-css/tokens": "^1.0.1",
31+
"@spectrum-css/tokens": "^1.0.4",
3232
"gulp": "^4.0.0"
3333
},
3434
"publishConfig": {

0 commit comments

Comments
 (0)