Skip to content

Commit 1a1a61d

Browse files
committed
chore: minor tooling and infra updates
1 parent 8abdbb1 commit 1a1a61d

File tree

4 files changed

+11
-12
lines changed

4 files changed

+11
-12
lines changed

.changeset/giant-scissors-protect.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

.changeset/pre.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@
119119
"fuzzy-brooms-jam",
120120
"fuzzy-jokes-begin",
121121
"gentle-ties-hang",
122-
"giant-scissors-protect",
123122
"gold-countries-fly",
124123
"good-dots-thank",
125124
"good-parrots-attack",

.github/workflows/lint.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,24 +76,29 @@ jobs:
7676
shell: bash
7777
run: yarn install --immutable
7878

79+
# Components must be built before linting so that the custom properties are available
80+
# in the dependencies for passthrough and token verification
81+
- name: Build components & ui-icons
82+
shell: bash
83+
run: yarn build
84+
7985
- name: Lint component styles
8086
if: ${{ inputs.styles_added_files != '' || inputs.styles_modified_files != '' }}
8187
uses: reviewdog/action-stylelint@v1.30.0
8288
with:
8389
fail_level: error
90+
filter_mode: diff_context
8491
level: error
8592
reporter: github-pr-review
86-
filter_mode: diff_context
8793
# stylelint_input: "components/*/index.css components/*/themes/*.css"
8894
stylelint_input: "${{ inputs.styles_added_files }} ${{ inputs.styles_modified_files }}"
8995
stylelint_config: stylelint.config.js
90-
packages: 'stylelint-header stylelint-config-standard stylelint-selector-bem-pattern stylelint-order stylelint-use-logical'
9196

9297
- name: Run eslint on packages and stories
93-
uses: reviewdog/action-eslint@v1.31.0
98+
uses: reviewdog/action-eslint@v1.33.0
9499
if: ${{ inputs.eslint_added_files != '' || inputs.eslint_modified_files != '' }}
95100
with:
96-
fail_on_error: true
101+
fail_level: error
97102
level: error
98103
reporter: github-pr-review
99104
filter_mode: diff_context

components/stepper/index.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@
247247
&:focus {
248248
--mod-infield-button-border-color: var(--highcontrast-stepper-border-color, var(--mod-stepper-border-color-focus, var(--spectrum-stepper-border-color-focus)));
249249

250-
/* stylelint-disable-next-line max-nesting-depth */
250+
/* stylelint-disable-next-line max-nesting-depth -- @todo reduce complexity of selectors */
251251
&:hover {
252252
--mod-infield-button-border-color: var(--highcontrast-stepper-border-color, var(--mod-stepper-border-color-focus-hover, var(--spectrum-stepper-border-color-focus-hover)));
253253
}
@@ -256,7 +256,7 @@
256256
&.is-keyboardFocused {
257257
--mod-infield-button-border-color: var(--highcontrast-stepper-border-color, var(--mod-stepper-border-color-keyboard-focus, var(--spectrum-stepper-border-color-keyboard-focus)));
258258

259-
/* stylelint-disable-next-line max-nesting-depth */
259+
/* stylelint-disable-next-line max-nesting-depth -- @todo reduce complexity of selectors */
260260
&:hover {
261261
--mod-infield-button-border-color: var(--highcontrast-stepper-border-color, var(--mod-stepper-border-color-hover, var(--spectrum-stepper-border-color-hover)));
262262
}

0 commit comments

Comments
 (0)